Fix running timezone-sensitive tests in IntelliJ IDEA #358
Conversation
ksobolew
force-pushed
the
kudi/fix-system-props-again
branch
from
00819ad to
973990a
Compare
|
thanks update CHANGES too |
ksobolew
force-pushed
the
kudi/fix-system-props-again
branch
from
973990a to
cb4feb2
Compare
Done |
ksobolew
force-pushed
the
kudi/fix-system-props-again
branch
from
cb4feb2 to
e3a8945
Compare
...under the correct version now |
CHANGES.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| Airbase 140 | |||
|
|
|||
| * Pass `user.timezone` in tests as a system property, not as a JMV argument | |||
There was a problem hiding this comment.
what does JMV stand for?
also mention that this supposedly restores IntelliJ ability to set timezone correctly when running tests from within that IDE.
There was a problem hiding this comment.
what does JMV stand for?
Oops. JVM, obviously.
also mention that this supposedly restores IntelliJ ability to set timezone correctly when running tests from within that IDE.
Done.
ksobolew
force-pushed
the
kudi/fix-system-props-again
branch
from
e3a8945 to
6f596e0
Compare
|
Can you update the commit message to say “fix xxxx”? You can mention that it’s a partial revert of something else in the commit message, but that’s unnecessary for the title of the commit. |
ksobolew
force-pushed
the
kudi/fix-system-props-again
branch
from
6f596e0 to
6a9a23c
Compare
Sure; done |
|
the new commit title is which isn't exactly 100% correct. we were passing timezone information to surefire correctly |
Some time ago, some properties were moved to `argLine` because Surefire incorrectly passes the `user.language` and `user.region` system properties to the tests. At that time, the `user.timezone` also got along for the ride, but it turns out, that that latter property *is* passed correctly. So while it works for Maven and Surefire, moving it into `argLine` causes IntelliJ IDEA to not pick it up, which in turn means that some tests are not working properly when executed inside the IDE. We can move it safely back, as it improves quality of life. This reverts parts of commit d4630aa.
ksobolew
force-pushed
the
kudi/fix-system-props-again
branch
from
6a9a23c to
04a382a
Compare
ksobolew
changed the title
You're right, I changed the title and reworded the commit message a bit too. |
|
Merged, thanks! |
Some time ago, some properties were moved to
argLinebecause Surefire incorrectly passes theuser.languageanduser.regionsystem properties to the tests. At that time, theuser.timezonealso got along for the ride, but it turns out, that that latter property is passed correctly. So while it works for Maven and Surefire, moving it intoargLinecauses IntelliJ IDEA to not pick it up, which in turn means that some tests are not working properly when executed inside the IDE. We can move it safely back, as it improves quality of life.This reverts parts of commit d4630aa.