feat: Auth Logic, Call pagination and filtering, unit and e2e tests, websocket, ci/cd #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
June 14, 2024 16:53
…ency path for phone-test, ensuring correct dependencies are installed.
…ency path for phone-test, ensuring correct dependencies are installed.
…ency path for phone-test, ensuring correct dependencies are installed.
…ency path for phone-test, ensuring correct dependencies are installed.
…d improve filter functionality.
…nd add reset functionality with a button.
…nd add reset functionality with a button.
geryit
changed the title
geryit
changed the title
geryit
commented
Jun 14, 2024
| env: | ||
| # For recording and parallelization to work you must set your CYPRESS_RECORD_KEY | ||
| # in GitHub repo → Settings → Secrets → Actions | ||
| CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }} |
There was a problem hiding this comment.
We need to add CYPRESS_RECORD_KEY to Github Action secrets to make this work. Once secret is added, we can get detailed reports on https://cypress.io
geryit
commented
Jun 14, 2024
Comment on lines
+3
to
+4
| on: | ||
| push: |
There was a problem hiding this comment.
For demo purposes, deployment runs on every push. We replace with
on:
push:
branches:
- masterbefore production
…tests, removed ".idea" from .gitignore, and removed unused handleFilterChange function from CallList index.tsx.
geryit
commented
Jun 14, 2024
Comment on lines
+3
to
+4
| export default defineConfig({ | ||
| projectId: "vq61f6", |
… Filters.tsx This commit corrects a typo in the file path for the import of callDirectionOptions and callTypeOptions in Filters.tsx. The file path has been updated from "./constats" to "./constants".
geryit
commented
Jun 14, 2024
| import { ApolloClient, HttpLink, InMemoryCache, split } from "@apollo/client"; | ||
| import { setContext } from "@apollo/client/link/context"; | ||
| import { WebSocketLink } from "@apollo/client/link/ws"; | ||
| import { SubscriptionClient } from "subscriptions-transport-ws"; |
There was a problem hiding this comment.
subscriptions-transport-ws is not maintained anymore, we need to switch to graphql-ws in the future (uses a different protocol)
geryit
commented
Jun 14, 2024
Comment on lines
+1
to
+23
| import { useEffect } from "react"; | ||
| import { ApolloError } from "@apollo/client"; | ||
| import { useNavigate } from "react-router-dom"; | ||
| import { useToast } from "@aircall/tractor"; | ||
|
|
||
| // Redirect to login page if the error is "Unauthorized" | ||
| const useRedirectToLogin = (error: ApolloError | undefined) => { | ||
| const navigate = useNavigate(); | ||
| const { showToast } = useToast(); | ||
|
|
||
| useEffect(() => { | ||
| if (error?.message === "Unauthorized") { | ||
| showToast({ | ||
| message: "Your session has expired, please login again", | ||
| variant: "warning", | ||
| dismissIn: 5000 | ||
| }); | ||
| navigate("/login", { replace: true }); | ||
| } | ||
| }, [error, navigate, showToast]); | ||
| }; | ||
|
|
||
| export default useRedirectToLogin; |
There was a problem hiding this comment.
A hook that listens to auth error and forwards users to the login page.
geryit
commented
Jun 14, 2024
|
|
||
| useEffect(() => { | ||
| if (subscriptionData) { | ||
| refetch(); |
There was a problem hiding this comment.
listen to subscription and refetch
added 6 commits
June 14, 2024 20:01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a range of critical enhancements and bug fixes to the calls list view , authentication features, and style changes. The primary updates include:
Junior Software Engineer Contributions:
Pagination Improvement: Fixed the pagination dropdown to correctly update the number of calls displayed per page.
Filtering Feature: Added filtering functionality in the calls list view, allowing users to filter by call type or direction.
Grouping Calls by Date: Implemented a feature to group calls made on the same day into one section for better readability.
Google.Chrome.-.React.App.2024-06-14.at.8.00.31.PM.mp4
Software Engineer Contributions
Google.Chrome.-.React.App.2024-06-14.at.7.14.31.PM.mp4
Google.Chrome.-.React.App.2024-06-14.at.7.40.55.PM.mp4
Senior Software Engineer Contributions
Google.Chrome.-.Default.Project.2024-06-14.at.7.27.05.PM.mp4
Google.Chrome.-.React.App.2024-06-14.at.7.33.42.PM.mp4
Staff Engineer and Above Contributions
Added a Github workflow that runs the tests and deploys to Vercel: deploy
Live demo: https://phone-test-ruddy.vercel.app