Source Github: add 3 new streams (workflows, workflow runs and repository vulnerability) #9251

bzAmin · 2022-01-03T16:41:03Z

…eam for the connector asana

What

Describe what the change is solving
For 2 connectors GitHub and asana
GitHub : Adding 3 streams Workflows, Workflow runs and vulnerability alert
Asana : We collect all the stories of a task but we don't have the task id. Added in the parse_response.

How

Create 3 new streams for the GitHub source.
Add a parse response for the Asana stream "stories" to add the task_id

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Not impactful for the users

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

This change is

…eam for the connector asana

CLAassistant · 2022-01-03T16:41:08Z

All committers have signed the CLA.

marcosmarxm · 2022-01-03T22:36:15Z

@bzAmin thanks for the contribution, can you sign the CLA?

marcosmarxm · 2022-01-03T23:05:18Z

@bzAmin can you run ./gradlew format and bump the connectors version for Asana and Github? see here

marcosmarxm · 2022-01-04T00:29:55Z

airbyte-integrations/connectors/source-github/source_github/streams.py

+        return "POST"
+
+    def path(self, stream_slice: Mapping[str, Any] = None, **kwargs) -> str:
+        return f"graphql"


remove the f-string.

marcosmarxm · 2022-01-04T00:31:24Z

airbyte-integrations/connectors/source-github/source_github/streams.py

+
+# Security streams
+
+class Security(GithubStream):


Maybe a more meaningful name like RepositoryVulnerabilityAlert

bzAmin · 2022-01-04T09:15:43Z

Hello ! I performed the changes. I'm waiting the review to perform the third step in the documentation publishing a connector :

One of Airbyte maintainers will review the change and publish the new version of the connector to Docker hub. Triggering tests and publishing connectors can be done by leaving a comment on the PR with the following format (the PR must be from the Airbyte repo, not a fork):

bzAmin · 2022-01-04T10:21:15Z

concerning the ./gradlew format : I ran ./gradlew :airbyte-integrations:connectors:source-github:build. Is it what you meant?
Thanks for your review.

marcosmarxm · 2022-01-04T16:19:05Z

concerning the ./gradlew format : I ran ./gradlew :airbyte-integrations:connectors:source-github:build. Is it what you meant? Thanks for your review.

yes, thanks @bzAmin
also can you sign the CLA?

bzAmin · 2022-01-04T17:09:01Z

Hello @marcosmarxm ! Done the CLA has been signed.

bzAmin · 2022-01-11T08:40:29Z

Hello, any news on this pull request ? thanks for your review.

…r-9251

marcosmarxm

some comments, sorry the delay @bzAmin !!!

airbyte-integrations/connectors/source-github/source_github/streams.py

airbyte-integrations/connectors/source-asana/source_asana/streams.py

bzAmin · 2022-01-19T13:40:40Z

Hello @marcosmarxm changes has been made. Thanks for your review

…r-9251

bzAmin · 2022-01-26T14:48:21Z

Hello @marcosmarxm, thanks for your code approval. Can you please approve the workflow?

marcosmarxm · 2022-03-30T23:52:44Z

sorry the delay I need to remove the vulnerability report, feel free to submit another PR adding that stream.

3 new streams to the github api and adding task_id in the stories str…

8921fc2

…eam for the connector asana

github-actions bot added the area/connectors Connector related issues label Jan 3, 2022

octavia-squidington-iii added the community label Jan 3, 2022

marcosmarxm reviewed Jan 4, 2022

View reviewed changes

marcosmarxm self-assigned this Jan 4, 2022

pull request update bump version GitHub Asana

239508a

igrankova added connectors/sources-api connectors/source/asana connectors/source/github labels Jan 5, 2022

marcosmarxm added 2 commits January 14, 2022 00:24

Merge branch 'master' of github.com:bzAmin/airbyte into marcos/test-p…

de7fd9f

…r-9251

correct schema

759afc7

marcosmarxm requested changes Jan 19, 2022

View reviewed changes

airbyte-integrations/connectors/source-github/source_github/streams.py Outdated Show resolved Hide resolved

airbyte-integrations/connectors/source-asana/source_asana/streams.py Outdated Show resolved Hide resolved

github-actions bot added area/api Related to the api area/documentation Improvements or additions to documentation area/frontend area/platform issues related to the platform area/protocol area/scheduler area/server area/worker Related to worker CDK Connector Development Kit labels Jan 19, 2022

Merge branch 'master' into master

ad2891b

bzAmin changed the title ~~3 new streams to the github api and adding task_id in the stories str…~~ 3 new streams to the github api Jan 19, 2022

bzAmin requested a review from marcosmarxm January 20, 2022 09:57

marcosmarxm added 2 commits January 24, 2022 23:08

Merge branch 'master' of github.com:bzAmin/airbyte into marcos/test-p…

89771a7

…r-9251

merge master + fix schema

2e04397

marcosmarxm changed the title ~~3 new streams to the github api~~ Source Github: add 3 new streams (workflows, workflow runs and repository vulnerability) Jan 25, 2022

marcosmarxm approved these changes Jan 25, 2022

View reviewed changes

fix schema

611ba53

marcosmarxm added 16 commits January 27, 2022 22:32

fix schemad

65659b4

solve conflic

bd11df9

Merge branch 'master' of github.com:airbytehq/airbyte

d330dfc

Merge branch 'master' of github.com:airbytehq/airbyte

cabf744

merge master

292aa8b

Merge branch 'master' into marcos/test-pr-9251

eb95a8a

correct teams stream

2507736

remove stream and fix some files

48688fc

remove config catalog

847f5bb

correct schema

9896500

solve conflict

696eb1f

solve fb conflict

1d01db8

solve final conflict with files

866eddb

correct github streams

08d4d07

correct assignes in config_catalog

1bcccaa

update docs and bump connector version

f91c8fe

github-actions bot added the area/documentation Improvements or additions to documentation label Mar 30, 2022

marcosmarxm merged commit a203d68 into airbytehq:master Mar 30, 2022

octavia-squidington-iii mentioned this pull request Mar 31, 2022

Bump Airbyte version from 0.35.62-alpha to 0.35.63-alpha #11624

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Github: add 3 new streams (workflows, workflow runs and repository vulnerability) #9251

Source Github: add 3 new streams (workflows, workflow runs and repository vulnerability) #9251

bzAmin commented Jan 3, 2022 •

edited by benmoriceau

Loading

CLAassistant commented Jan 3, 2022 •

edited

Loading

marcosmarxm commented Jan 3, 2022 •

edited

Loading

marcosmarxm commented Jan 3, 2022

marcosmarxm Jan 4, 2022

marcosmarxm Jan 4, 2022

bzAmin commented Jan 4, 2022

bzAmin commented Jan 4, 2022

marcosmarxm commented Jan 4, 2022

bzAmin commented Jan 4, 2022 •

edited

Loading

bzAmin commented Jan 11, 2022

marcosmarxm left a comment

bzAmin commented Jan 19, 2022

bzAmin commented Jan 26, 2022 •

edited

Loading

marcosmarxm commented Mar 30, 2022

Source Github: add 3 new streams (workflows, workflow runs and repository vulnerability) #9251

Source Github: add 3 new streams (workflows, workflow runs and repository vulnerability) #9251

Conversation

bzAmin commented Jan 3, 2022 • edited by benmoriceau Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

CLAassistant commented Jan 3, 2022 • edited Loading

marcosmarxm commented Jan 3, 2022 • edited Loading

marcosmarxm commented Jan 3, 2022

marcosmarxm Jan 4, 2022

Choose a reason for hiding this comment

marcosmarxm Jan 4, 2022

Choose a reason for hiding this comment

bzAmin commented Jan 4, 2022

bzAmin commented Jan 4, 2022

marcosmarxm commented Jan 4, 2022

bzAmin commented Jan 4, 2022 • edited Loading

bzAmin commented Jan 11, 2022

marcosmarxm left a comment

Choose a reason for hiding this comment

bzAmin commented Jan 19, 2022

bzAmin commented Jan 26, 2022 • edited Loading

marcosmarxm commented Mar 30, 2022

bzAmin commented Jan 3, 2022 •

edited by benmoriceau

Loading

CLAassistant commented Jan 3, 2022 •

edited

Loading

marcosmarxm commented Jan 3, 2022 •

edited

Loading

bzAmin commented Jan 4, 2022 •

edited

Loading

bzAmin commented Jan 26, 2022 •

edited

Loading