Update fields in source-connectors specifications: retently #9045

igrankova · 2021-12-22T14:42:13Z

What

Add title and description properties to each field in source-connectors specifications:
source-retently

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

igrankova · 2021-12-22T14:48:17Z

/test connector=connectors/source-retently

🕑 connectors/source-retently https://github.com/airbytehq/airbyte/actions/runs/1611793267
✅ connectors/source-retently https://github.com/airbytehq/airbyte/actions/runs/1611793267
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 base_python/__init__.py                       13      0   100%
	 base_python/catalog_helpers.py                10      6    40%
	 base_python/cdk/__init__.py                    0      0   100%
	 base_python/cdk/abstract_source.py            89     64    28%
	 base_python/cdk/streams/__init__.py            0      0   100%
	 base_python/cdk/streams/auth/__init__.py       0      0   100%
	 base_python/cdk/streams/auth/core.py           8      1    88%
	 base_python/cdk/streams/auth/jwt.py            5      5     0%
	 base_python/cdk/streams/auth/oauth.py         37     26    30%
	 base_python/cdk/streams/auth/token.py          9      4    56%
	 base_python/cdk/streams/core.py               63     32    49%
	 base_python/cdk/streams/exceptions.py         10      2    80%
	 base_python/cdk/streams/http.py               67     33    51%
	 base_python/cdk/streams/rate_limiting.py      30     14    53%
	 base_python/cdk/utils/__init__.py              0      0   100%
	 base_python/cdk/utils/casing.py                4      0   100%
	 base_python/cdk/utils/event_timing.py         47      3    94%
	 base_python/client.py                         56     33    41%
	 base_python/entrypoint.py                     70     56    20%
	 base_python/integration.py                    52     25    52%
	 base_python/logger.py                         33     15    55%
	 base_python/schema_helpers.py                 56     41    27%
	 base_python/source.py                         51     34    33%
	 main_dev.py                                    3      3     0%
	 --------------------------------------------------------------
	 TOTAL                                        713    397    44%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                          Stmts   Miss  Cover
	 -------------------------------------------------
	 source_retently/__init__.py       2      0   100%
	 source_retently/source.py        74      8    89%
	 -------------------------------------------------
	 TOTAL                            76      8    89%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestFullRefresh.test_sequential_reads because not found in the config
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 15 passed, 2 skipped in 11.62s ========================

airbyte-integrations/connectors/source-retently/source_retently/spec.json

annalvova05

Also, please add the changelog message.

…y/spec.json Update description Co-authored-by: Anna Lvova <[email protected]>

…y/spec.json Update Description Co-authored-by: Anna Lvova <[email protected]>

…e-description' into igrankova/issue-8914-update-title-description

annalvova05 · 2021-12-28T12:08:10Z

/test connector=connectors/source-retently

🕑 connectors/source-retently https://github.com/airbytehq/airbyte/actions/runs/1630403930
✅ connectors/source-retently https://github.com/airbytehq/airbyte/actions/runs/1630403930
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                          Stmts   Miss  Cover
	 -------------------------------------------------
	 source_retently/__init__.py       2      0   100%
	 source_retently/source.py        74      8    89%
	 -------------------------------------------------
	 TOTAL                            76      8    89%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestFullRefresh.test_sequential_reads because not found in the config
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 15 passed, 2 skipped in 11.76s ========================

annalvova05 · 2021-12-28T12:16:06Z

/publish connector=connectors/source-retently

🕑 connectors/source-retently https://github.com/airbytehq/airbyte/actions/runs/1630426503
✅ connectors/source-retently https://github.com/airbytehq/airbyte/actions/runs/1630426503

Files title/description update for issue # 8914

be29cfe

igrankova self-assigned this Dec 22, 2021

github-actions bot added the area/connectors Connector related issues label Dec 22, 2021

igrankova linked an issue Dec 22, 2021 that may be closed by this pull request

Update fields in source-connectors specifications: retently #8914

Closed

igrankova temporarily deployed to more-secrets December 22, 2021 14:42 Inactive

Version update for issue # 8914

df32205

igrankova temporarily deployed to more-secrets December 22, 2021 14:45 Inactive

jrhizor temporarily deployed to more-secrets December 22, 2021 14:50 Inactive

igrankova requested a review from annalvova05 December 28, 2021 08:31

annalvova05 reviewed Dec 28, 2021

View reviewed changes

airbyte-integrations/connectors/source-retently/source_retently/spec.json Outdated Show resolved Hide resolved

annalvova05 reviewed Dec 28, 2021

View reviewed changes

airbyte-integrations/connectors/source-retently/source_retently/spec.json Outdated Show resolved Hide resolved

annalvova05 suggested changes Dec 28, 2021

View reviewed changes

igrankova and others added 2 commits December 28, 2021 12:00

Update airbyte-integrations/connectors/source-retently/source_retentl…

9b49dd2

…y/spec.json Update description Co-authored-by: Anna Lvova <[email protected]>

Update airbyte-integrations/connectors/source-retently/source_retentl…

7e76a6e

…y/spec.json Update Description Co-authored-by: Anna Lvova <[email protected]>

igrankova temporarily deployed to more-secrets December 28, 2021 10:02 Inactive

annalvova05 self-requested a review December 28, 2021 11:18

annalvova05 added 2 commits December 28, 2021 14:02

add doc

ed2b9c2

Merge remote-tracking branch 'origin/igrankova/issue-8914-update-titl…

93576b4

…e-description' into igrankova/issue-8914-update-title-description

github-actions bot added the area/documentation Improvements or additions to documentation label Dec 28, 2021

annalvova05 temporarily deployed to more-secrets December 28, 2021 12:05 Inactive

add doc

5004be0

annalvova05 temporarily deployed to more-secrets December 28, 2021 12:06 Inactive

jrhizor temporarily deployed to more-secrets December 28, 2021 12:10 Inactive

annalvova05 approved these changes Dec 28, 2021

View reviewed changes

jrhizor temporarily deployed to more-secrets December 28, 2021 12:17 Inactive

bump version

63bb5aa

annalvova05 merged commit 1e4eea2 into master Dec 28, 2021

annalvova05 deleted the igrankova/issue-8914-update-title-description branch December 28, 2021 12:26

annalvova05 temporarily deployed to more-secrets December 28, 2021 12:27 Inactive

jrhizor mentioned this pull request Jan 3, 2022

Bump Airbyte version from 0.35.2-alpha to 0.35.3-alpha #9262

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update fields in source-connectors specifications: retently #9045

Update fields in source-connectors specifications: retently #9045

igrankova commented Dec 22, 2021

igrankova commented Dec 22, 2021 •

edited by github-actions bot

Loading

annalvova05 left a comment

annalvova05 commented Dec 28, 2021 •

edited by github-actions bot

Loading

annalvova05 commented Dec 28, 2021 •

edited by github-actions bot

Loading

Update fields in source-connectors specifications: retently #9045

Update fields in source-connectors specifications: retently #9045

Conversation

igrankova commented Dec 22, 2021

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

igrankova commented Dec 22, 2021 • edited by github-actions bot Loading

annalvova05 left a comment

Choose a reason for hiding this comment

annalvova05 commented Dec 28, 2021 • edited by github-actions bot Loading

annalvova05 commented Dec 28, 2021 • edited by github-actions bot Loading

igrankova commented Dec 22, 2021 •

edited by github-actions bot

Loading

annalvova05 commented Dec 28, 2021 •

edited by github-actions bot

Loading

annalvova05 commented Dec 28, 2021 •

edited by github-actions bot

Loading