-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added associations to some CRM Object streams in Hubspot connector #9027
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, after is ready to go!
"deal_pipelines": DealPipelineStream(**common_params), | ||
"deals": DealStream(associations=["contacts"], **common_params), | ||
"deals": DealStream(associations=["contacts", "companies"], **common_params), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding new associations change the response from the API. You need to change the schema file to be compatible with the new response.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah of course @marcosmarxm!
I've updated the schemas to include the relevant associations. Seems like the deals
stream schema has always had the companies
associations so I didn't add that.
@ksoenandar can you run |
@marcosmarxm - any idea why it was failing? I tried running the integration test but I'm encountering this error: |
This looks a problem with Java, do you have Java 17 installed? |
@marcosmarxm - Yeah I do actually. Went through a couple of troubleshooting from Stack Overflow and it's not working either. Any other suggestion on how I can run the integration test? |
Ok @marcosmarxm - managed to solve the Java dependencies issue. I ran that command that you asked for but I'm not sure what I'm looking for. I got the following error log message from that command:
But not quite sure what this means? |
Hey @marcosmarxm - update here: I tried forking airbyte's master repo and run the same command for the source hubspot directory as is and I'm encountering the same error message. So doesn't sound like the error is coming from the changes that I made? |
thanks @ksoenandar I'd published your changes here #10631 |
What
Very minor change - added company associations to contacts, deals and tickets CRM object streams.
🚨 User Impact 🚨
None, the only change is the instantiation of the streams in the
client.py
file in the Hubspot source connector.This change is