Update "Building a connector the hard way" doc #9008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/documentation
edgao
force-pushed
the
edgao/connector-the-hard-way
branch
from
8901a38
to
512bd22
Compare
edgao
changed the title
sherifnada
approved these changes
Dec 21, 2021
docs/connector-development/tutorials/build-a-connector-the-hard-way.md
Outdated
Show resolved
Hide resolved
| @@ -836,7 +836,7 @@ A full connector in less than 200 lines of code. Not bad! We're now ready to pac | |||
|
|
|||
| Our connector is very lightweight, so the Dockerfile needed to run it is very light as well. We edit the autogenerated `Dockerfile` so that its contents are as followed: | |||
|
|
|||
| ```text | |||
| ```Dockerfile | |||
There was a problem hiding this comment.
FWIW if gitbook doesn't show know what Dockerfile is supposed to do it might format it completely incorrectly. This isn't displayed on gitbook so no issues for now.
There was a problem hiding this comment.
yay markdown. at the very least vscode and github both display this correctly, so 🤞
|
also @edgao fwiw if there are portions of the PR template which are irrelevant (e.g: customer impact or checklist in this case) you can delete them to reduce visual clutter |
Co-authored-by: Sherif A. Nada <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update docs for clarity and correctness
How
Recommended reading order
First commit is pure whitespace. Next two commits are the interesting ones.