-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(charts): Set new migration values and use bootloader image #8843
feat(charts): Set new migration values and use bootloader image #8843
Conversation
274efd9
to
0b1b69f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @vnourdin
@vnourdin can you solve the conflict so I can merge your contirbution? |
@marcosmarxm it's done ! |
Thanks @vnourdin, ready to merge! |
@vnourdin we have another PR which is also adding the env var for flyway job and config minimum versions. In his PR @mohamagdy exposed these env var as helm values. It's also a valid approach but I'm under the impression that it's fine to hardcode them in the |
@alafanechere I don't have a strong opinion on whether the values should come from the configmap or be plain env vars. As long as it's easily configured whether the helm chart, I think it's ok! |
I think it's always better to put everything that can change in values so that users only change one file. |
What
since #8584, the server pod use some new variables, and we should use the bootloader image that manage db migrations.
This PR add everything needed in the helm chart.
How