Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fields in source-connectors specifications: drift, harvest, hubspot, intercom, monday, clickhouse, bing-ads, snapchat-marketing, microsoft-teams #8429

Merged
merged 40 commits into from
Dec 16, 2021
Merged

Update fields in source-connectors specifications: drift, harvest, hubspot, intercom, monday, clickhouse, bing-ads, snapchat-marketing, microsoft-teams #8429

merged 40 commits into from
Dec 16, 2021

Conversation

ycherniaiev
Copy link
Contributor

@ycherniaiev ycherniaiev commented Dec 2, 2021 •
edited
Loading

What

Add title and description properties to each field in source-connectors specifications:
source-drift
source-harvest
source-hubspot
source-intercom
source-clickhouse
source-snapchat-marketing
source-bing-ads
source-microsoft-teams
source-monday

@ycherniaiev ycherniaiev added the area/connectors Connector related issues label Dec 2, 2021
@ycherniaiev ycherniaiev requested a review from lazebnyi December 2, 2021 12:03
@ycherniaiev ycherniaiev linked an issue Dec 2, 2021 that may be closed by this pull request
Update fields in source-connectors specifications: drift, harvest, hubspot, intercom, notion, monday, microsoft-teams, bing-ads, clickhouse, snapchat-marketing #8361
Closed
grubberr
grubberr suggested changes Dec 2, 2021
View reviewed changes
airbyte-integrations/connectors/source-bing-ads/source_bing_ads/spec.json Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-bing-ads/source_bing_ads/spec.json Outdated
@@ -64,37 +65,44 @@
},
"client_id": {
"type": "string",
"description": "ID of your Microsoft Advertising client application.",
"title": "Client ID",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stil tabs

airbyte-integrations/connectors/source-intercom/source_intercom/spec.json Outdated Show resolved Hide resolved
@ycherniaiev ycherniaiev temporarily deployed to more-secrets December 2, 2021 14:17 Inactive
@ycherniaiev ycherniaiev self-assigned this Dec 2, 2021
@ycherniaiev ycherniaiev requested review from grubberr and removed request for lazebnyi December 2, 2021 14:23
@ycherniaiev ycherniaiev temporarily deployed to more-secrets December 2, 2021 15:15 Inactive
@ycherniaiev ycherniaiev temporarily deployed to more-secrets December 3, 2021 11:06 Inactive
@ycherniaiev ycherniaiev temporarily deployed to more-secrets December 3, 2021 11:13 Inactive
@ycherniaiev ycherniaiev temporarily deployed to more-secrets December 3, 2021 11:41 Inactive
grubberr
grubberr suggested changes Dec 3, 2021
View reviewed changes
airbyte-integrations/connectors/source-hubspot/source_hubspot/spec.json Outdated
@@ -75,7 +75,7 @@
"order": 0
},
"api_key": {
"title": "API key",
"title": "API key",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'title' need to move one space right ?

airbyte-integrations/connectors/source-intercom/source_intercom/spec.json Outdated
@@ -6,17 +6,18 @@
"type": "object",
"required": ["start_date", "access_token"],
"additionalProperties": true,
"properties": {
"properties":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lost '{'

airbyte-integrations/connectors/source-monday/source_monday/spec.json Outdated
@@ -9,7 +9,8 @@
"properties": {
"api_token": {
"type": "string",
"description": "This is the API token to authenticate requests to Monday. Profile picture (bottom left) => Admin => API",
"title": "Personal Access Token"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lost comma

@ycherniaiev ycherniaiev temporarily deployed to more-secrets December 3, 2021 13:34 Inactive
@grubberr grubberr self-requested a review December 3, 2021 13:36
@grubberr grubberr requested a review from nataliekwong December 3, 2021 13:36
@ycherniaiev ycherniaiev temporarily deployed to more-secrets December 6, 2021 10:35 Inactive
@ycherniaiev ycherniaiev changed the title Update fields in source-connectors specifications: drift, harvest, hubspot, intercom, notion, monday, microsoft-teams, bing-ads, snapchat-marketing, clickhouse Update fields in source-connectors specifications: drift, harvest, hubspot, intercom, notion, monday, microsoft-teams, bing-ads, snapchat-marketing Dec 6, 2021
@grubberr
Copy link
Contributor

grubberr commented Dec 16, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-monday

🕑 connectors/source-monday https://github.com/airbytehq/airbyte/actions/runs/1588158158
✅ connectors/source-monday https://github.com/airbytehq/airbyte/actions/runs/1588158158

@grubberr
Copy link
Contributor

grubberr commented Dec 16, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-clickhouse

🕑 connectors/source-clickhouse https://github.com/airbytehq/airbyte/actions/runs/1588166159
✅ connectors/source-clickhouse https://github.com/airbytehq/airbyte/actions/runs/1588166159

@jrhizor jrhizor temporarily deployed to more-secrets December 16, 2021 15:25 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 16, 2021 15:27 Inactive
@grubberr
Copy link
Contributor

grubberr commented Dec 16, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-harvest

🕑 connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/1588174794
✅ connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/1588174794

@jrhizor jrhizor temporarily deployed to more-secrets December 16, 2021 15:29 Inactive
@grubberr
Copy link
Contributor

grubberr commented Dec 16, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-intercom

🕑 connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/1588189255
✅ connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/1588189255

@jrhizor jrhizor temporarily deployed to more-secrets December 16, 2021 15:32 Inactive
@grubberr
Copy link
Contributor

grubberr commented Dec 16, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-microsoft-teams

🕑 connectors/source-microsoft-teams https://github.com/airbytehq/airbyte/actions/runs/1588209014
✅ connectors/source-microsoft-teams https://github.com/airbytehq/airbyte/actions/runs/1588209014

@jrhizor jrhizor temporarily deployed to more-secrets December 16, 2021 15:37 Inactive
@grubberr
source_specs.yaml updated
0994855 
Signed-off-by: Sergey Chvalyuk <[email protected]>
@grubberr grubberr temporarily deployed to more-secrets December 16, 2021 15:52 Inactive
@grubberr grubberr merged commit 2ad4ca1 into master Dec 16, 2021
@grubberr grubberr deleted the ycherniaiev/issue-8361-update-title-descriptions branch December 16, 2021 15:52
@jrhizor jrhizor mentioned this pull request Dec 17, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@ycherniaiev @grubberr @schlattk
Update fields in source-connectors specifications: drift, harvest, hu…
270ebc5 
…bspot, intercom, monday, clickhouse, bing-ads, snapchat-marketing, microsoft-teams (airbytehq#8429)

Signed-off-by: Sergey Chvalyuk <[email protected]>

Co-authored-by: Sergey Chvalyuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igrankova igrankova igrankova approved these changes

@nataliekwong nataliekwong nataliekwong approved these changes

@sherifnada sherifnada sherifnada approved these changes

@grubberr grubberr grubberr approved these changes

Assignees

@ycherniaiev ycherniaiev

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/bing-ads connectors/source/clickhouse connectors/source/drift connectors/source/harvest connectors/source/hubspot connectors/source/intercom connectors/source/microsoft-teams connectors/source/monday connectors/source/snapchat-marketing connectors/sources-api connectors/sources-database
Projects
No open projects
GL Roadmap
Archived in project
Milestone
No milestone
6 participants
@ycherniaiev @grubberr @sherifnada @nataliekwong @igrankova @jrhizor