Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Linnworks: refactor stream StockLocations #8169

Merged
merged 15 commits into from
Nov 29, 2021

Conversation

monai
Copy link
Contributor

@monai monai commented Nov 22, 2021

What

This PR refactors private stream Location, which was embedded into stream StockLocation, to public stream StockLocationDetails utilizing HttpSubStream. From now on, StockLocations can be synced independently, while StockLocationDetails performs single sync of StockLocations, resulting in N+1 requests.

Recommended reading order

  1. streams.py
  2. source.py

🚨 User Impact 🚨

🚨🚨 This PR changes the stream StockLocations schema.

Pre-merge Checklist

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@github-actions github-actions bot added the area/connectors Connector related issues label Nov 22, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Nov 22, 2021
@monai monai changed the title 🎉 Source Linnworks: refactor stream StockLocations Source Linnworks: refactor stream StockLocations Nov 22, 2021
@alafanechere alafanechere self-assigned this Nov 23, 2021
@alafanechere alafanechere temporarily deployed to more-secrets November 25, 2021 13:59 Inactive
Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @monai for this cool refacto, I made minor suggestions + committed the docker image version bump. Let me know if you plan to make the suggested modification, I'll publish the docker image update from my side branch.

@monai
Copy link
Contributor Author

monai commented Nov 26, 2021

Thanks @monai for this cool refacto, I made minor suggestions + committed the docker image version bump. Let me know if you plan to make the suggested modification, I'll publish the docker image update from my side branch.

Thank you for review. I'm going to make changes on monday.

@alafanechere alafanechere temporarily deployed to more-secrets November 29, 2021 10:58 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 29, 2021 11:15 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets November 29, 2021 13:26 Inactive
@alafanechere
Copy link
Contributor

Thanks for the changes and this clean contrib, ready for merge! 🎉

@alafanechere alafanechere merged commit afbbd6e into airbytehq:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants