-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Exchange Rates: add ignore_weekends boolean option #7936
Source Exchange Rates: add ignore_weekends boolean option #7936
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment and it's ready, can you update the Changelog in docs too?
airbyte-integrations/connectors/source-exchange-rates/source_exchange_rates/source.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Marcos Marx <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Any chance someone can help add the start_date to be the "yesterday"? I just need 1 record of each day in my table but it seems when it runs daily it does it syncs for the full period since the start_date defined (I'm 3 days in and burned all my free credits). @lizdeika you able to help? |
Hi, |
…7936) * Source Exchange Rates: add ignore_weekends boolean option * unformat * backward compatibility for ignore_weekends option Co-authored-by: Marcos Marx <[email protected]> * Add changelog Co-authored-by: Marcos Marx <[email protected]>
What
By default Exchange Rates source connector ignores weekends.
But there are situations when gaps in exchange rate dates are not an option.
How
This PR adds an ability to enable or disable the ignoring of weekends.
Defaults to true(current behavior) -> Ignore weekends on sync
Recommended reading order
Pre-merge Checklist
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes