Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Exchange Rates: add ignore_weekends boolean option #7936

Merged

Conversation

lizdeika
Copy link
Contributor

What

By default Exchange Rates source connector ignores weekends.
But there are situations when gaps in exchange rate dates are not an option.

How

This PR adds an ability to enable or disable the ignoring of weekends.
Defaults to true(current behavior) -> Ignore weekends on sync

Recommended reading order

Pre-merge Checklist

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Nov 12, 2021
@lizdeika lizdeika changed the title Exchange rates ignore weekends boolean Source Exchange Rates: add ignore_weekends boolean option Nov 12, 2021
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment and it's ready, can you update the Changelog in docs too?

@marcosmarxm marcosmarxm self-assigned this Nov 13, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Nov 15, 2021
@lizdeika lizdeika requested a review from marcosmarxm November 15, 2021 18:34
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@marcosmarxm marcosmarxm merged commit ebc8b76 into airbytehq:master Nov 18, 2021
@lizdeika lizdeika deleted the exchange-rates-ignore-weekends-boolean branch November 18, 2021 09:24
@niteshsharoff
Copy link

Any chance someone can help add the start_date to be the "yesterday"? I just need 1 record of each day in my table but it seems when it runs daily it does it syncs for the full period since the start_date defined (I'm 3 days in and burned all my free credits).

@lizdeika you able to help?

@lizdeika
Copy link
Contributor Author

Hi,
My guess is you have "Connection" Sync mode setup as "Full refresh" so it resyncs everything from the start every time.
You should setup "Connection" Sync mode as Incremental | Deduped + History and choose base and date as Primary key.

schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
…7936)

* Source Exchange Rates: add ignore_weekends boolean option

* unformat

* backward compatibility for ignore_weekends option

Co-authored-by: Marcos Marx <[email protected]>

* Add changelog

Co-authored-by: Marcos Marx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/sources-api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants