Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 New Source DB2 secure-only #7792

Merged
merged 19 commits into from
Nov 11, 2021
Merged

🎉 New Source DB2 secure-only #7792

merged 19 commits into from
Nov 11, 2021

Conversation

andriikorotkov
Copy link
Contributor

What

Create new source-db2-strict-encrypt

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@andriikorotkov
added ssl conection to source-db2 and added new acceptance tests
c84681c
@andriikorotkov
Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…
46ac8bc 
…6434-db2-sorce-destination

� Conflicts:
�	airbyte-integrations/connectors/source-db2/src/main/java/io.airbyte.integrations.source.db2/Db2Source.java
@andriikorotkov
updated ssl source-db2 version
3c32358
@andriikorotkov
updated ssl source-db2 version
eea6d77
@andriikorotkov
updated ssl source-db2 version
74d3f65
@andriikorotkov
updated ssl source-db2 version
9f303d4
@andriikorotkov
updated spec
77bcb5d
@andriikorotkov
fixed code style
8aff5dd
@andriikorotkov
marked encryption as required and add NPE checker
7e150cf
@andriikorotkov
Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…
366decd 
…6434-db2-sorce-destination

� Conflicts:
�	airbyte-config/init/src/main/resources/seed/source_definitions.yaml
@andriikorotkov
created source-db2-strict-encrypt
bae1b00
@andriikorotkov
Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…
27dbdd0 
…6718-db2-strict-encrypt
@github-actions github-actions bot added the area/connectors Connector related issues label Nov 9, 2021
@andriikorotkov andriikorotkov temporarily deployed to more-secrets November 10, 2021 15:43 Inactive
@andriikorotkov andriikorotkov temporarily deployed to more-secrets November 10, 2021 15:46 Inactive
@andriikorotkov andriikorotkov temporarily deployed to more-secrets November 10, 2021 15:56 Inactive
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Nov 10, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-db2-strict-encrypt

🕑 connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1445092431
❌ connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1445092431
🐛 https://gradle.com/s/egwei3dzexxu4

@jrhizor jrhizor temporarily deployed to more-secrets November 10, 2021 16:21 Inactive
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Nov 10, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-db2-strict-encrypt

🕑 connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1445560202
❌ connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1445560202
🐛 https://gradle.com/s/b5oxv3uh4dfjy

@jrhizor jrhizor temporarily deployed to more-secrets November 10, 2021 18:20 Inactive
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Nov 10, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-db2-strict-encrypt

🕑 connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1445571601
❌ connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1445571601
🐛 https://gradle.com/s/ucrgks6ajoc7k

@andriikorotkov andriikorotkov temporarily deployed to more-secrets November 10, 2021 18:22 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 10, 2021 18:23 Inactive
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Nov 10, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-db2-strict-encrypt

🕑 connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1445708839
❌ connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1445708839
🐛 https://gradle.com/s/wdssnrgatnlyq

@andriikorotkov andriikorotkov temporarily deployed to more-secrets November 10, 2021 19:02 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 10, 2021 19:03 Inactive
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Nov 10, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-db2-strict-encrypt

🕑 connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1445848616
✅ connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1445848616
No Python unittests run

@andriikorotkov andriikorotkov temporarily deployed to more-secrets November 10, 2021 19:41 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 10, 2021 19:41 Inactive
@andriikorotkov andriikorotkov marked this pull request as ready for review November 10, 2021 20:07
alexandr-shegeda
alexandr-shegeda approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@alexandr-shegeda alexandr-shegeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. we can proceed with publish/merge, no need to wait for airbyte review

...ns/io/airbyte/integration_tests/sources/Db2StrictEncryptSourceCertificateAcceptanceTest.java Show resolved Hide resolved
@alexandr-shegeda alexandr-shegeda linked an issue Nov 10, 2021 that may be closed by this pull request
Create a secure-only Db2 source #6718
Closed
6 tasks
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Nov 11, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-db2-strict-encrypt

🕑 connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1447672757
✅ connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1447672757

@andriikorotkov andriikorotkov temporarily deployed to more-secrets November 11, 2021 06:53 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 11, 2021 06:54 Inactive
@andriikorotkov andriikorotkov merged commit def1667 into master Nov 11, 2021
@andriikorotkov andriikorotkov deleted the akorotkov/6718-db2-strict-encrypt branch November 11, 2021 07:59
@jrhizor jrhizor mentioned this pull request Nov 11, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@andriikorotkov @schlattk
🎉 New Source DB2 secure-only (airbytehq#7792)
5f72b29 
* added ssl conection to source-db2 and added new acceptance tests

* updated ssl source-db2 version

* updated ssl source-db2 version

* updated ssl source-db2 version

* updated ssl source-db2 version

* updated spec

* fixed code style

* marked encryption as required and add NPE checker

* created source-db2-strict-encrypt

* fixed minor remarks

* fixed code style

* fixed code style

* fixed code style

* updated acceptance tests

* added java doc for certificate generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurii-bidiuk yurii-bidiuk yurii-bidiuk approved these changes

@alexandr-shegeda alexandr-shegeda alexandr-shegeda approved these changes

@etsybaev etsybaev Awaiting requested review from etsybaev

Assignees
No one assigned
Labels
area/connectors Connector related issues connectors/source/db2-strict-encrypt connectors/source/db2 connectors/sources-database
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a secure-only Db2 source
5 participants
@andriikorotkov @alexandr-shegeda @yurii-bidiuk @jrhizor @karinakuz