-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 New Source: Linnworks #7588
🎉 New Source: Linnworks #7588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I greatly appreciate the improvements you made 🙇 .
I made some other non blocking comments, mainly related to unit tests. Let me know if you plan to work on this.
I confirm that I successfully ran the unit and acceptance test with our Linnworks sandbox account.
airbyte-integrations/connectors/source-linnworks/unit_tests/test_incremental_streams.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-linnworks/unit_tests/test_streams.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-linnworks/unit_tests/test_streams.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-linnworks/unit_tests/test_streams.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-linnworks/unit_tests/test_streams.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-linnworks/unit_tests/test_streams.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-linnworks/unit_tests/test_source.py
Show resolved
Hide resolved
stream = LinnworksStream() | ||
requests_mock.get("https://dummy", headers={header_name: header_value}, status_code=429) | ||
result = stream.backoff_time(requests.get("https://dummy")) | ||
assert result == expected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you did not test Locations
😄
airbyte-integrations/connectors/source-linnworks/unit_tests/test_incremental_streams.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-linnworks/unit_tests/test_incremental_streams.py
Show resolved
Hide resolved
Class |
…st_streams.py Co-authored-by: Augustin <[email protected]>
… augustin/publish-new-source-linnworks
Hello @monai ! Sorry to not finished your contribution before the date stipulated in the contest. All contributions made before 15-November are eligible to receive the award. We're trying to review your contribution as soon as possible. |
Thanks for this new connector @monai 🎉 |
What
Upstream API documentation:
Sources:
How
The source queries Linnworks HTTP API using Python CDK and applies the following transformations:
Recommended reading order
Pre-merge Checklist
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described here