Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 New Source: Linnworks #7588

Merged
merged 104 commits into from
Nov 15, 2021
Merged

🎉 New Source: Linnworks #7588

merged 104 commits into from
Nov 15, 2021

Conversation

monai
Copy link
Contributor

@monai monai commented Nov 3, 2021

What

Upstream API documentation:

Sources:

  • StockLocations
  • StockItems
  • ProcessedOrders

How

The source queries Linnworks HTTP API using Python CDK and applies the following transformations:

  • Converts all JSON object keys from TitleCase to snake_case.

Recommended reading order

  1. source.py
  2. util.py

Pre-merge Checklist

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@github-actions github-actions bot added the area/connectors Connector related issues label Nov 3, 2021
Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I greatly appreciate the improvements you made 🙇 .
I made some other non blocking comments, mainly related to unit tests. Let me know if you plan to work on this.
I confirm that I successfully ran the unit and acceptance test with our Linnworks sandbox account.

stream = LinnworksStream()
requests_mock.get("https://dummy", headers={header_name: header_value}, status_code=429)
result = stream.backoff_time(requests.get("https://dummy"))
assert result == expected
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you did not test Locations 😄

@monai
Copy link
Contributor Author

monai commented Nov 12, 2021

I think you did not test Locations 😄

Class Location is a "private" class and is a part of StockLocations. Its output presence is tested in test_stock_locations.

@marcosmarxm
Copy link
Member

Hello @monai ! Sorry to not finished your contribution before the date stipulated in the contest. All contributions made before 15-November are eligible to receive the award. We're trying to review your contribution as soon as possible.

@alafanechere alafanechere temporarily deployed to more-secrets November 15, 2021 17:21 Inactive
@alafanechere alafanechere merged commit ea738f1 into airbytehq:master Nov 15, 2021
@alafanechere
Copy link
Contributor

Thanks for this new connector @monai 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation bounty community connectors/source/linnworks
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

6 participants