Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CockroachDb source: Add only encrypted version for the connector #7457

Merged
merged 17 commits into from
Nov 24, 2021
Merged

CockroachDb source: Add only encrypted version for the connector #7457

merged 17 commits into from
Nov 24, 2021

Conversation

DoNotPanicUA
Copy link
Contributor

@DoNotPanicUA DoNotPanicUA commented Oct 28, 2021 •
edited
Loading

Add strict SSL source version for the CockroachDb source

@DoNotPanicUA DoNotPanicUA temporarily deployed to more-secrets October 28, 2021 15:29 Inactive
@github-actions github-actions bot added the area/connectors Connector related issues label Oct 28, 2021
@DoNotPanicUA DoNotPanicUA temporarily deployed to more-secrets October 28, 2021 15:34 Inactive
@alexandr-shegeda alexandr-shegeda linked an issue Oct 29, 2021 that may be closed by this pull request
Create a secure-only CockroachDb source #6717
Closed
6 tasks
@VitaliiMaltsev
Copy link
Contributor

seems like you have failed test
cockroach
s

@DoNotPanicUA DoNotPanicUA temporarily deployed to more-secrets November 18, 2021 21:29 Inactive
@DoNotPanicUA DoNotPanicUA temporarily deployed to more-secrets November 22, 2021 09:11 Inactive
@DoNotPanicUA DoNotPanicUA temporarily deployed to more-secrets November 22, 2021 09:15 Inactive
@DoNotPanicUA DoNotPanicUA temporarily deployed to more-secrets November 22, 2021 13:36 Inactive
@DoNotPanicUA

This comment has been minimized.

Sign in to view
@DoNotPanicUA

This comment has been minimized.

Sign in to view
@jrhizor jrhizor temporarily deployed to more-secrets November 22, 2021 14:09 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 22, 2021 14:09 Inactive
@DoNotPanicUA DoNotPanicUA temporarily deployed to more-secrets November 22, 2021 14:22 Inactive
@DoNotPanicUA DoNotPanicUA temporarily deployed to more-secrets November 22, 2021 14:29 Inactive
@DoNotPanicUA

This comment has been minimized.

Sign in to view
@DoNotPanicUA

This comment has been minimized.

Sign in to view
@jrhizor jrhizor temporarily deployed to more-secrets November 22, 2021 14:32 Inactive
@DoNotPanicUA

This comment has been minimized.

Sign in to view
@DoNotPanicUA DoNotPanicUA temporarily deployed to more-secrets November 22, 2021 16:28 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 22, 2021 16:30 Inactive
@DoNotPanicUA

This comment has been minimized.

Sign in to view
@jrhizor jrhizor temporarily deployed to more-secrets November 22, 2021 20:50 Inactive
@DoNotPanicUA

This comment has been minimized.

Sign in to view
@DoNotPanicUA DoNotPanicUA temporarily deployed to more-secrets November 22, 2021 21:02 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 22, 2021 21:03 Inactive
@DoNotPanicUA
Merge remote-tracking branch 'origin/master' into aleonets/6717-cockr…
32fd97f 
…oachdb-only-encrypted

# Conflicts:
#	airbyte-config/init/src/main/resources/seed/source_specs.yaml
@DoNotPanicUA DoNotPanicUA temporarily deployed to more-secrets November 23, 2021 16:37 Inactive
@DoNotPanicUA DoNotPanicUA temporarily deployed to more-secrets November 23, 2021 17:04 Inactive
@DoNotPanicUA

This comment has been minimized.

Sign in to view
@jrhizor jrhizor temporarily deployed to more-secrets November 23, 2021 17:07 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Nov 23, 2021
@DoNotPanicUA DoNotPanicUA temporarily deployed to more-secrets November 23, 2021 17:48 Inactive
@DoNotPanicUA
Copy link
Contributor Author

DoNotPanicUA commented Nov 23, 2021 •
edited by github-actions bot
Loading

/test connector=source-cockroachdb-strict-encrypt

🕑 source-cockroachdb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1496011190
✅ source-cockroachdb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1496011190
No Python unittests run

@jrhizor jrhizor temporarily deployed to more-secrets November 23, 2021 17:53 Inactive
@DoNotPanicUA DoNotPanicUA marked this pull request as ready for review November 23, 2021 18:09
alexandr-shegeda
alexandr-shegeda approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@alexandr-shegeda alexandr-shegeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. we can proceed with publishing and merge without airbyte review

@DoNotPanicUA
Copy link
Contributor Author

DoNotPanicUA commented Nov 23, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-cockroachdb-strict-encrypt

🕑 connectors/source-cockroachdb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1496742724
✅ connectors/source-cockroachdb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1496742724

@jrhizor jrhizor temporarily deployed to more-secrets November 23, 2021 21:32 Inactive
@DoNotPanicUA DoNotPanicUA merged commit 1417b8e into master Nov 24, 2021
@DoNotPanicUA DoNotPanicUA deleted the aleonets/6717-cockroachdb-only-encrypted branch November 24, 2021 08:46
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@DoNotPanicUA @schlattk
CockroachDb source: Add only encrypted version for the connector (air…
e033f6c 
…bytehq#7457)

* [6717] Add only encrypted version for the CockroachDb

* format

* Create custom docker for CockroachDB with SSL

* add custom docker + test

* enable container

* set Cockroach version and add container to integration test

* fix docker

* remove test

* fix version

* fix container instancing scope

* left only integration test

* remove ssl from expected spec

* fix urls

* clean import

* chang log + build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandr-shegeda alexandr-shegeda alexandr-shegeda approved these changes

@VitaliiMaltsev VitaliiMaltsev Awaiting requested review from VitaliiMaltsev

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/cockroachdb-strict-encrypt connectors/sources-database
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a secure-only CockroachDb source
5 participants
@DoNotPanicUA @VitaliiMaltsev @alexandr-shegeda @jrhizor @karinakuz