Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Jira: Make recently added configs optional for backwards compatibility #7222

Merged
merged 3 commits into from
Oct 22, 2021
Merged

Source Jira: Make recently added configs optional for backwards compatibility #7222

merged 3 commits into from
Oct 22, 2021

Conversation

cjwooo
Copy link
Contributor

@cjwooo cjwooo commented Oct 20, 2021

What

Previous Jira PR 1fcd6c4 added some required config parameters, which broke backwards compatibility.

How

Make those config parameters optional.

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Oct 20, 2021
@cjwooo
Copy link
Contributor Author

cjwooo commented Oct 20, 2021

@sherifnada Followup to #6621

@cjwooo cjwooo mentioned this pull request Oct 20, 2021
Merged
38 tasks
@marcosmarxm
Copy link
Member

marcosmarxm commented Oct 20, 2021 •
edited
Loading

thanks @cjwooo will review ASAP. Can you bump the connector version in Dockerfile, docs and inside airbyte-config SEED and SOURCE_FILE files? (see instructions here)

@cjwooo
Copy link
Contributor Author

cjwooo commented Oct 20, 2021

@marcosmarxm Done

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Oct 20, 2021
marcosmarxm
marcosmarxm approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and Published #7269

@marcosmarxm marcosmarxm merged commit 17961fc into airbytehq:master Oct 22, 2021
@jrhizor jrhizor mentioned this pull request Oct 25, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@cjwooo @schlattk
Source Jira: Make recently added configs optional for backwards compa…
2c7cdce 
…tibility (airbytehq#7222)

* Make start_date optional

* Make projects optional

* Bump version
@cjwooo cjwooo deleted the cwu/jira3 branch January 26, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

@marcosmarxm marcosmarxm marcosmarxm approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjwooo @marcosmarxm @sherifnada @octavia-squidington-iii