Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Source Facebook Pages: bump FB API version #7128

Merged
merged 3 commits into from
Oct 22, 2021
Merged

🎉 Source Facebook Pages: bump FB API version #7128

merged 3 commits into from
Oct 22, 2021

Conversation

gaart
Copy link
Contributor

@gaart gaart commented Oct 18, 2021 •
edited
Loading

What

Update facebook api version to v12.0

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 18, 2021
@gaart gaart linked an issue Oct 18, 2021 that may be closed by this pull request
Facebook Pages connector needs to be upgraded to v.12 #7052
Closed
@gaart gaart temporarily deployed to more-secrets October 18, 2021 15:57 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 18, 2021 15:59 Inactive
@gaart
Copy link
Contributor Author

gaart commented Oct 18, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-facebook-pages

🕑 connectors/source-facebook-pages https://github.com/airbytehq/airbyte/actions/runs/1355489919
❌ connectors/source-facebook-pages https://github.com/airbytehq/airbyte/actions/runs/1355489919
🐛 https://gradle.com/s/wel3dohnmkwzy

@jrhizor jrhizor temporarily deployed to more-secrets October 18, 2021 16:06 Inactive
@gaart
Copy link
Contributor Author

gaart commented Oct 19, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-facebook-pages

🕑 connectors/source-facebook-pages https://github.com/airbytehq/airbyte/actions/runs/1359334440
✅ connectors/source-facebook-pages https://github.com/airbytehq/airbyte/actions/runs/1359334440
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                Stmts   Miss  Cover
	 -------------------------------------------------------
	 source_facebook_pages/__init__.py       2      0   100%
	 source_facebook_pages/metrics.py        4      0   100%
	 source_facebook_pages/source.py        20     11    45%
	 source_facebook_pages/streams.py       72     34    53%
	 -------------------------------------------------------
	 TOTAL                                  98     45    54%

@gaart gaart temporarily deployed to more-secrets October 19, 2021 13:26 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 19, 2021 13:27 Inactive
gaart
gaart commented Oct 19, 2021
View reviewed changes
airbyte-integrations/connectors/source-facebook-pages/source_facebook_pages/metrics.py
@@ -122,7 +122,6 @@
"category_list",
"checkins",
"company_overview",
"connected_instagram_account",
"connected_page_backed_instagram_account",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've removed these fields because updated API requires new permissions to access them.
Should we ask users to re-generate their tokens instead? Or removing these fields is ok?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt we update scopes for oauth?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. We should ask users to regenerate their token. For OSS users this should be pretty straightforward, and since this isn't yet on Cloud then there are no tokens to regenerate. But we have to be super clear about the action required from users in the changelog, because the changelog will be the source of truth for users
  2. We should update oauth scopes accordingly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like in addition to updating permissions and regenerating the token user needs to create and connect an Instagram business account, as well as accept an additional user agreement. What should we do in this case?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh crap. Ok let's remove this then. Not all pages will have a connected instagram profiel.

@gaart
Copy link
Contributor Author

gaart commented Oct 22, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-facebook-pages

🕑 connectors/source-facebook-pages https://github.com/airbytehq/airbyte/actions/runs/1371486836
✅ connectors/source-facebook-pages https://github.com/airbytehq/airbyte/actions/runs/1371486836
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                Stmts   Miss  Cover
	 -------------------------------------------------------
	 source_facebook_pages/__init__.py       2      0   100%
	 source_facebook_pages/metrics.py        4      0   100%
	 source_facebook_pages/source.py        20     11    45%
	 source_facebook_pages/streams.py       72     34    53%
	 -------------------------------------------------------
	 TOTAL                                  98     45    54%

@jrhizor jrhizor temporarily deployed to more-secrets October 22, 2021 09:02 Inactive
@gaart
Copy link
Contributor Author

gaart commented Oct 22, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-facebook-pages

🕑 connectors/source-facebook-pages https://github.com/airbytehq/airbyte/actions/runs/1371540130
✅ connectors/source-facebook-pages https://github.com/airbytehq/airbyte/actions/runs/1371540130

@jrhizor jrhizor temporarily deployed to more-secrets October 22, 2021 09:16 Inactive
@gaart gaart merged commit cb6408a into master Oct 22, 2021
@gaart gaart deleted the gaart/7052-update-facebook-pages branch October 22, 2021 11:35
@jrhizor jrhizor mentioned this pull request Oct 25, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@gaart @schlattk
🎉 Source Facebook Pages: bump FB API version (airbytehq#7128)
15831a3 
* Upd FB API version

* Upd changelog

* Exclude fields with extra permissions required
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada left review comments

@avida avida avida left review comments

@vitaliizazmic vitaliizazmic vitaliizazmic approved these changes

@keu keu keu approved these changes

@eliziario eliziario Awaiting requested review from eliziario

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/facebook-pages connectors/sources-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Facebook Pages connector needs to be upgraded to v.12
7 participants
@gaart @avida @keu @sherifnada @vitaliizazmic @jrhizor @igrankova