Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 New Source: Salesloft #6962

Merged
merged 9 commits into from
Oct 22, 2021
Merged

🎉 New Source: Salesloft #6962

merged 9 commits into from
Oct 22, 2021

Conversation

prasrvenkat
Copy link
Contributor

@prasrvenkat prasrvenkat commented Oct 11, 2021 •
edited
Loading

What

  • This contribution mainly from my colleague/friend @lgomezm, I just addressed few check-list items before submitting here.
  • Adding Salesloft as new source. Fixes New Source: SalesLoft #4471
  • Just few streams to start with, uses OAuth.

How

Implemented

Recommended reading order

  1. spec.json
  2. Schemas under schemas/*.json
  3. source.py

Test Runs

Integration Tests

image

Unit Tests

image

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@CLAassistant
Copy link

CLAassistant commented Oct 11, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 11, 2021
@prasrvenkat prasrvenkat mentioned this pull request Oct 11, 2021
Closed
@marcosmarxm marcosmarxm mentioned this pull request Oct 13, 2021
Closed
marcosmarxm
marcosmarxm requested changes Oct 13, 2021
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @prasrvenkat made some comments! Overall looks good, I'll test locally and submit other comments after this first interaction! Thanks a loooot

airbyte-integrations/connectors/source-salesloft/source_salesloft/source.py Show resolved Hide resolved
airbyte-integrations/connectors/source-salesloft/source_salesloft/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-salesloft/source_salesloft/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-salesloft/source_salesloft/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-salesloft/source_salesloft/source.py Outdated Show resolved Hide resolved
@marcosmarxm marcosmarxm self-assigned this Oct 13, 2021
@prasrvenkat
Copy link
Contributor Author

Hi @prasrvenkat made some comments! Overall looks good, I'll test locally and submit other comments after this first interaction! Thanks a loooot

Thanks @marcosmarxm! I will address these and tag you

@prasrvenkat
Copy link
Contributor Author

Hi @prasrvenkat made some comments! Overall looks good, I'll test locally and submit other comments after this first interaction! Thanks a loooot

Thanks @marcosmarxm! I will address these and tag you

Ok pushed the changes, sorry for the delay @marcosmarxm

@marcosmarxm
Copy link
Member

No problem @prasrvenkat I'm going to test and validate your connector later today.

marcosmarxm
marcosmarxm approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and Published in #7274

@marcosmarxm marcosmarxm merged commit 115af27 into airbytehq:master Oct 22, 2021
@marcosmarxm marcosmarxm mentioned this pull request Oct 22, 2021
Closed
@jrhizor jrhizor mentioned this pull request Oct 25, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@prasrvenkat @lgomezm @schlattk
🎉 New Source: Salesloft (airbytehq#6962)
a27b710 
* Generated connector source code

* Added basic users stream

* Added people stream

* Added cadences and cadence_memberships streams

* Updated unit tests

* Fixed docker build

* Updated connector to use OAuth

* address some checklist items

* review comments

Co-authored-by: lgomezm <[email protected]>
@prasrvenkat prasrvenkat deleted the lgomez/salesloft_connector branch January 12, 2022 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm approved these changes

Assignees

@marcosmarxm marcosmarxm

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation bounty community connectors/source/salesloft
Projects
No open projects
Community Contributed PRs
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Source: SalesLoft
7 participants
@prasrvenkat @CLAassistant @marcosmarxm @avaidyanatha @octavia-squidington-iii @octavia-squidington-iv @lgomezm