Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Shopify: support oauth flow #6951

Merged
merged 6 commits into from
Oct 14, 2021
Merged

Conversation

bazarnov
Copy link
Collaborator

What

#6257 - Source Shopify: Support oauth connections

How

  • edited spec.json with auth_method implementation.
  • edited ShopifyAuthenticator class to accept new OAuth access_token variable.
  • bumped the version
  • added new config_oauth.json for SAT

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@github-actions github-actions bot added the area/connectors Connector related issues label Oct 11, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Oct 11, 2021
@bazarnov bazarnov temporarily deployed to more-secrets October 11, 2021 14:31 Inactive
@bazarnov bazarnov linked an issue Oct 11, 2021 that may be closed by this pull request
@jrhizor jrhizor temporarily deployed to more-secrets October 11, 2021 17:58 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets October 11, 2021 18:41 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 12, 2021 08:08 Inactive
@bazarnov
Copy link
Collaborator Author

bazarnov commented Oct 12, 2021

/test connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1332341654
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1332341654
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 /actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-shopify/.venv/lib/python3.8/site-packages/coverage/control.py:761: CoverageWarning: No data was collected. (no-data-collected)
	 Name                          Stmts   Miss  Cover
	 -------------------------------------------------
	 source_shopify/__init__.py        2      2     0%
	 source_shopify/auth.py           20     20     0%
	   self._warn("No data was collected.", slug="no-data-collected")
	 source_shopify/source.py        193    193     0%
	 source_shopify/transform.py      53     53     0%
	 source_shopify/utils.py          57     57     0%
	 -------------------------------------------------
	 TOTAL                           325    325     0%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                          Stmts   Miss  Cover
	 -------------------------------------------------
	 source_shopify/__init__.py        2      0   100%
	 source_shopify/auth.py           20     11    45%
	 source_shopify/source.py        193     79    59%
	 source_shopify/transform.py      53      0   100%
	 source_shopify/utils.py          57      6    89%
	 -------------------------------------------------
	 TOTAL                           325     96    70%

@jrhizor jrhizor temporarily deployed to more-secrets October 12, 2021 08:54 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets October 12, 2021 12:28 Inactive
@bazarnov
Copy link
Collaborator Author

bazarnov commented Oct 13, 2021

/test connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1337216681
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1337216681
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                          Stmts   Miss  Cover
	 -------------------------------------------------
	 source_shopify/__init__.py        2      2     0%
	 source_shopify/auth.py           20     20     0%
	 source_shopify/source.py        193    193     0%
	 source_shopify/transform.py      53     53     0%
	 source_shopify/utils.py          57     57     0%
	 -------------------------------------------------
	 TOTAL                           325    325     0%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                          Stmts   Miss  Cover
	 -------------------------------------------------
	 source_shopify/__init__.py        2      0   100%
	 source_shopify/auth.py           20     11    45%
	 source_shopify/source.py        193     79    59%
	 source_shopify/transform.py      53      0   100%
	 source_shopify/utils.py          57      6    89%
	 -------------------------------------------------
	 TOTAL                           325     96    70%

@bazarnov bazarnov temporarily deployed to more-secrets October 13, 2021 11:23 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 13, 2021 11:24 Inactive
@bazarnov
Copy link
Collaborator Author

bazarnov commented Oct 14, 2021

/publish connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1343122718
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1343122718

@jrhizor jrhizor temporarily deployed to more-secrets October 14, 2021 18:53 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets October 14, 2021 19:18 Inactive
@bazarnov bazarnov merged commit cfae84c into master Oct 14, 2021
@bazarnov bazarnov deleted the bazarnov/6257-shopify-oauth branch October 14, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Shopify: support oauth
3 participants