Create a secure-only MongoDb destination #6945
Conversation
| @Override | ||
| public ConnectorSpecification modifySpec(ConnectorSpecification originalSpec) throws Exception { | ||
| final ConnectorSpecification spec = Jsons.clone(originalSpec); | ||
| ((ObjectNode) spec.getConnectionSpecification().get("properties").get("instance_type").get("oneOf").get(0).get("properties")).remove("tls"); |
There was a problem hiding this comment.
Can you add a comment here why the tls property is removed? Something like "remove the boolean TLS option to enforce TLS connection".
There was a problem hiding this comment.
In addition, it seems that simply removing this property is not enough. In the original destination code:
instanceConfig.get(TLS).asBoolean()If the tls property is undefined, the above statement will throw null pointer exception. Can you also update that to do a null check, and default its value to true?
There was a problem hiding this comment.
Can you add a comment here why the
tlsproperty is removed? Something like "remove the boolean TLS option to enforce TLS connection".
Thanks, added.
There was a problem hiding this comment.
In addition, it seems that simply removing this property is not enough. In the original destination code:
instanceConfig.get(TLS).asBoolean()If the
tlsproperty is undefined, the above statement will throw null pointer exception. Can you also update that to do anullcheck, and default its value totrue?
Thanks for noticing it, one commit with this change and test was lost, sorry for that, everything is in place now.
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This expected_spec file is defined, but never used. Can you add a unit test / acceptance test for this secure only connector?
There was a problem hiding this comment.
@irynakruk, thank you for the updates.
Please make sure to follow and check off the Pre-merge Checklist to make sure the connector is properly published.
github-actions
bot
added
the
area/documentation
|
/test connector=connectors/destination-mongodb
|
|
/test connector=connectors/destination-mongodb-strict-encrypt
|
|
/test connector=connectors/destination-mongodb-strict-encrypt
|
@tuliren thanks for review, I've pushed nitpick commit and small fixes for tests and dependencies. Also, I've bumped version for |
|
/publish connector=connectors/destination-mongodb
|
|
/publish connector=connectors/destination-mongodb-strict-encrypt
|
|
/publish connector=connectors/destination-mongodb-strict-encrypt
|
* Added mongodb destination strict encrypt
What
We want to create secure-only versions of connectors that can be used in the Airbyte cloud. The idea is that these connectors inherently prevent certain insecure connections such as connecting to a database over the public internet without encryption.
How
Created a new connector destination-mongodb-strict-encrypt based on the current connector, modified the connector's spec to hide any options which allow the user to disable TLS change the connector to enable TLS by default if the TLS option is not specified.
Recommended reading order
MongodbDestinationStrictEncrypt.javatestsPre-merge Checklist
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/SUMMARY.mddocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampledocs/integrations/README.mdairbyte-integrations/builds.mdAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described here