Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Stripe: use start_date parameter in incremental streams #6466

Merged
merged 2 commits into from
Sep 27, 2021

Conversation

Zirochkaa
Copy link
Contributor

@Zirochkaa Zirochkaa commented Sep 27, 2021

What

Closes #6074.

Pre-merge Checklist

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

@Zirochkaa Zirochkaa self-assigned this Sep 27, 2021
@Zirochkaa Zirochkaa temporarily deployed to more-secrets September 27, 2021 16:46 Inactive
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 27, 2021
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Sep 27, 2021

/test connector=source-stripe

🕑 source-stripe https://github.com/airbytehq/airbyte/actions/runs/1279192049
✅ source-stripe https://github.com/airbytehq/airbyte/actions/runs/1279192049
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                        Stmts   Miss  Cover
	 -----------------------------------------------
	 source_stripe/__init__.py       2      2     0%
	 source_stripe/source.py        20     20     0%
	 source_stripe/streams.py      160    160     0%
	 -----------------------------------------------
	 TOTAL                         182    182     0%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              158    109    31%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     25    39%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py      75     11    85%
	 ------------------------------------------------------------------------
	 TOTAL                                                  778    432    44%

@jrhizor jrhizor temporarily deployed to more-secrets September 27, 2021 16:49 Inactive
@CLAassistant
Copy link

CLAassistant commented Sep 27, 2021

CLA assistant check
All committers have signed the CLA.

@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Sep 27, 2021

/publish connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1279736896
✅ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1279736896

@Zirochkaa Zirochkaa temporarily deployed to more-secrets September 27, 2021 19:39 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets September 27, 2021 19:40 Inactive
@Zirochkaa Zirochkaa merged commit d9adbd3 into master Sep 27, 2021
@Zirochkaa Zirochkaa deleted the oleh/6074-use-start_date-in-stripe branch September 27, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the start_date parameter in the stripe connector
5 participants