-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add the ability to use a secret persistence #6415
Conversation
For step 1, just running a sync from the config repository while accessing a db-based secrets layer is running! |
docker-compose.yaml
Outdated
@@ -23,6 +23,8 @@ services: | |||
logging: *default-logging | |||
container_name: airbyte-db | |||
restart: unless-stopped | |||
ports: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: remove this before merging
…hout feature flagging
This reverts commit 489d2d5.
@@ -198,7 +201,7 @@ public static void init() throws URISyntaxException, IOException, InterruptedExc | |||
} | |||
|
|||
// by default use airbyte deployment governed by a test container. | |||
if (System.getenv("USE_EXTERNAL_DEPLOYMENT") == null || !System.getenv("USE_EXTERNAL_DEPLOYMENT").equalsIgnoreCase("true")) { | |||
if (!USE_EXTERNAL_DEPLOYMENT) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! I think this iteration makes some nice improvements.
there were a couple questions and naming things i pointed out that i think didn't get covered. it is fine if the answer is that you disagree and are going to skip them. just want to make sure they were seen.
This PR is meant to enable external secret persistences and optional coordinate-based secret access throughout the system.
It's probably most useful to start by looking at
ConfigRepository
and following through execution paths for syncs and check/discover workflows.There are a few things I'd like feedback on here:
If you want to play around with it locally I recommend setting
SECRET_PERSISTENCE
toTESTING_CONFIG_DB_TABLE
so you don't need to deal with GCP secrets.todos:
out of scope for this pr (create tickets):