Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛Destination S3 and GCS - Fixed connector's bug that prevent writing streams with more than 50GB #5890

Merged
merged 14 commits into from
Sep 17, 2021
Merged

🐛Destination S3 and GCS - Fixed connector's bug that prevent writing streams with more than 50GB #5890

merged 14 commits into from
Sep 17, 2021

Conversation

etsybaev
Copy link
Contributor

@etsybaev etsybaev commented Sep 7, 2021 •
edited
Loading

What

Currently, we can't write to S3 and GCS objects with more than 50GB of each

How

The reason is that servers allow 10,000 blocks max and currently we have block size hardcoded as 5MB. but servers allow to have it up to 5GB each.
To fix the described issue - added a new arg that allows to configure it. Basically, to reach the max object limit of 5TB - the max block's size of 525 (MB) is enough. The new arg supports size from 5MB (min for server) to 525MB.

https://cloud.google.com/storage/quotas
https://docs.aws.amazon.com/AmazonS3/latest/userguide/qfacts.html

Tested locally:
Selection_002
Selection_001
Selection_003
Selection_004

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@github-actions github-actions bot added the area/connectors Connector related issues label Sep 7, 2021
@etsybaev
Copy link
Contributor Author

etsybaev commented Sep 7, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/destination-s3

🕑 connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/1210702460
✅ connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/1210702460

@jrhizor jrhizor temporarily deployed to more-secrets September 7, 2021 19:18 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Sep 11, 2021
@etsybaev
Copy link
Contributor Author

etsybaev commented Sep 11, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/destination-s3

🕑 connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/1224756646
✅ connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/1224756646
🕑 connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/1224756646
✅ connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/1224756646
🕑 connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/1224756646
✅ connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/1224756646

@jrhizor jrhizor temporarily deployed to more-secrets September 11, 2021 17:11 Inactive
@etsybaev etsybaev changed the title [DRAFT_PR_IGNORE_IT] Made partsize config configurable for gcs and s3 [DRAFT_PR_IGNORE_IT] 🐛Destination S3 and GCS - Fixed connector's bug that prevent writing streams with more than 50GB Sep 11, 2021
@etsybaev etsybaev linked an issue Sep 11, 2021 that may be closed by this pull request
S3 and GCS writes are limited to 50GB #5720
Closed
@etsybaev
Copy link
Contributor Author

etsybaev commented Sep 11, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/destination-gcs

🕑 connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1224812601
✅ connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1224812601
🕑 connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1224812601
✅ connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1224812601
🕑 connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1224812601
✅ connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1224812601
🕑 connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1224812601
✅ connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1224812601
🕑 connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1224812601
✅ connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1224812601

@jrhizor jrhizor temporarily deployed to more-secrets September 11, 2021 17:48 Inactive
@alexandr-shegeda
Copy link
Contributor

LGTM

Merge branch 'master' into etsybaev/made-partsize-config-configurable…
099634d 
…-for-gcs-and-s3

# Conflicts:
#	docs/integrations/destinations/s3.md
@etsybaev etsybaev changed the title [DRAFT_PR_IGNORE_IT] 🐛Destination S3 and GCS - Fixed connector's bug that prevent writing streams with more than 50GB 🐛Destination S3 and GCS - Fixed connector's bug that prevent writing streams with more than 50GB Sep 14, 2021
@etsybaev etsybaev marked this pull request as ready for review September 14, 2021 08:39
davinchia
davinchia approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@davinchia davinchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Appreciate the screen shots. Appreciate all the test you added.

Small feedback from me - it would have been easier to review if the PR was split into the base S3 changes, and a follow up PR for GCS changes.

Please also go through the updating connector checklist in the future so it's easy for me to know what is/what is not done.

Thanks!

airbyte-integrations/connectors/destination-gcs/src/main/resources/spec.json Show resolved Hide resolved
...src/main/java/io/airbyte/integrations/destination/s3/util/S3StreamTransferManagerHelper.java Outdated Show resolved Hide resolved
@etsybaev
Copy link
Contributor Author

etsybaev commented Sep 17, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-s3

🕑 connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/1244622918
✅ connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/1244622918

@jrhizor jrhizor temporarily deployed to more-secrets September 17, 2021 07:45 Inactive
@etsybaev
Copy link
Contributor Author

etsybaev commented Sep 17, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-gcs

🕑 connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1244656389
❌ connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1244656389
🕑 connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1244656389
❌ connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1244656389
🕑 connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1244656389
❌ connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1244656389

@jrhizor jrhizor temporarily deployed to more-secrets September 17, 2021 07:58 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets September 17, 2021 08:24 Inactive
@etsybaev
Copy link
Contributor Author

etsybaev commented Sep 17, 2021 •
edited
Loading

Released new S3 connector, but can't release GCS due to other blocking bug - #6134

@etsybaev
Copy link
Contributor Author

Merging the latest master with a fix didn't help. It seems like we've got new issues in master that prevent merging. So still can't publish GCS and merge this

@sherifnada
Copy link
Contributor

sherifnada commented Sep 17, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-gcs

🕑 connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1246666581
✅ connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1246666581

@jrhizor jrhizor temporarily deployed to more-secrets September 17, 2021 19:04 Inactive
@sherifnada sherifnada merged commit 64ce6fd into master Sep 17, 2021
@sherifnada sherifnada deleted the etsybaev/made-partsize-config-configurable-for-gcs-and-s3 branch September 17, 2021 21:21
@jrhizor jrhizor mentioned this pull request Sep 18, 2021
Merged
@PS-istarostenko PS-istarostenko mentioned this pull request Sep 20, 2021
Closed
@PS-istarostenko
Copy link

@etsybaev can we please get the same fix, but for BigQuery and Snowflake when using GCS and S3 as a staging loading method?
#5720

@yurii-bidiuk yurii-bidiuk mentioned this pull request Dec 16, 2021
Closed
@rx007 rx007 mentioned this pull request Oct 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davinchia davinchia davinchia approved these changes

@alexandr-shegeda alexandr-shegeda alexandr-shegeda approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/gcs connectors/destinations-files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

S3 and GCS writes are limited to 50GB
7 participants
@etsybaev @alexandr-shegeda @sherifnada @PS-istarostenko @davinchia @jrhizor @karinakuz