Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery Denormalized NPE fix #5881

Merged
merged 4 commits into from
Sep 8, 2021
Merged

BigQuery Denormalized NPE fix #5881

merged 4 commits into from
Sep 8, 2021

Conversation

irynakruk
Copy link
Contributor

What

Connector: BigQuery Denormalized NPE when sync data from intercom

How

For empty nested objects and arrays added check to avoid NPE.

Recommended reading order

  1. BigQueryDenormalizedRecordConsumer.java
  2. docs

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 7, 2021
@irynakruk irynakruk requested a review from etsybaev September 7, 2021 13:41
@irynakruk irynakruk linked an issue Sep 7, 2021 that may be closed by this pull request
Connector: BigQuery Denormalized NPE when sync data from intercom #5525
Closed
etsybaev
etsybaev approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@etsybaev etsybaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irynakruk irynakruk marked this pull request as ready for review September 7, 2021 14:01
@irynakruk irynakruk requested a review from subodh1810 September 7, 2021 14:02
@irynakruk
Copy link
Contributor Author

irynakruk commented Sep 7, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1209771726
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1209771726

@jrhizor jrhizor temporarily deployed to more-secrets September 7, 2021 14:17 Inactive
subodh1810
subodh1810 approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@subodh1810 subodh1810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test case for such a scenario when fields would be empty?

@irynakruk
Copy link
Contributor Author

Can we add a test case for such a scenario when fields would be empty?

Sure.
@subodh1810 I've added, pls check

@irynakruk
Copy link
Contributor Author

irynakruk commented Sep 8, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1211693108
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1211693108

@jrhizor jrhizor temporarily deployed to more-secrets September 8, 2021 02:15 Inactive
@irynakruk
Copy link
Contributor Author

irynakruk commented Sep 8, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1211749648
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1211749648

@jrhizor jrhizor temporarily deployed to more-secrets September 8, 2021 02:40 Inactive
@irynakruk irynakruk merged commit 895430e into master Sep 8, 2021
@irynakruk irynakruk deleted the irynakruk/5525-bigquery-npe branch September 8, 2021 13:09
@jrhizor jrhizor mentioned this pull request Sep 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subodh1810 subodh1810 subodh1810 approved these changes

@etsybaev etsybaev etsybaev approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/bigquery-denormalized connectors/destinations-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connector: BigQuery Denormalized NPE when sync data from intercom
5 participants
@irynakruk @etsybaev @subodh1810 @jrhizor @karinakuz