Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 SAT: fix for handling None/null values of format date-time #5855

Closed
wants to merge 2 commits into from

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Sep 5, 2021

What

#5854 - SAT: cannot handle None/null with format date-time

How

  • added 1 line to check_datetime method.
  • added unit_test cases to cover the issue.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Code reviews completed
  • Documentation updated
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@bazarnov bazarnov linked an issue Sep 5, 2021 that may be closed by this pull request
@bazarnov bazarnov changed the title 🐛 SAT: fix for handling None/null values of format date-time. 🐛 SAT: fix for handling None/null values of format date-time Sep 5, 2021
@bazarnov
Copy link
Collaborator Author

bazarnov commented Sep 6, 2021

Resolved with #5798

@bazarnov bazarnov closed this Sep 6, 2021
@bazarnov bazarnov deleted the bazarnov/sat-nulls-datetime-fix branch September 20, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SAT: cannot handle None/null with format date-time
1 participant