-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 📝 DAT: verify that a destination is able to write any ISO8601-compliant date string #5814
🐛 📝 DAT: verify that a destination is able to write any ISO8601-compliant date string #5814
Conversation
airbyte-integrations/bases/standard-destination-test/src/main/resources/format_reference.txt
Show resolved
Hide resolved
airbyte-integrations/bases/standard-destination-test/src/main/resources/edge_case_messages.txt
Outdated
Show resolved
Hide resolved
airbyte-integrations/bases/standard-destination-test/src/main/resources/format_reference.txt
Show resolved
Hide resolved
discussed offline this morning: since almost all destinations are failing this test we'll keep this branch alive while we merge fixes for the destinations |
b33872c
to
c07047e
Compare
c07047e
to
043c576
Compare
043c576
to
0b5df6f
Compare
0b5df6f
to
2603ad8
Compare
The following integration tests are failed on the normalization phase with error like: invalid datetime '1/1/2021':
These two tests are failed with the message like: Invalid format: "20210101T0930" is malformed at "30". It should be fixed on the Java destination side (
|
…iant date string (airbytehq#5814) * added format_reference.txt, edited edge_case_messages.txt, edge_case_catalog.json Co-authored-by: Yurii Bidiuk <[email protected]>
…01-compliant date string (airbytehq#5814)" (airbytehq#8484) This reverts commit e4e95e3.
What
#5712 - Destination acceptance tests: verify that a destination is able to write any ISO8601-compliant date string
How
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described here