-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destination Oracle: use airbyte default column name + correct ci tests #5746
Conversation
/test connector=connectors/destination-oracle
|
var tables = getAllTables(database); | ||
tables.removeAll(allTables); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step is strange. We get all tables and remove all of them. The variable tables
was empty at the end and we didn't remove data/tables in tearDown. The function getAllTables(database)
get all tables where the user is the owner.
/publish connector=connectors/destination-oracle
|
What
2 things:
Use
"_AIRBYTE_DATA"
as column name in oracle destination. This will help us improving integrating Oracle in normalization module.After Destination Oracle: change table limit and format record data #5542 we started using Oracle AWS instance to run integration tests. The test/publish works when developing the PR but after that CI started failing consecutively. Reason: is because the function
tearDown
wasn't removing tables/data after each test. The problem occurs when the testtestLineBreakCharacters
ran beforetestIncrementalSync
the record inserted from first test was counted in the second one.How
Describe the solution
Recommended reading order
x.java
y.python
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
docs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes