Various shortio connector cleanups.

[davinchia]

What

Make sure the build passes, and tests can be run, and also release/publish.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

• Community member? Grant edit access to maintainers (instructions)
• Secrets in the connector's spec are annotated with airbyte_secret
• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• Code reviews completed
• Documentation updated
  • Connector's README.md
  • docs/SUMMARY.md
  • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • docs/integrations/README.md
  • airbyte-integrations/builds.md
• PR name follows PR naming conventions
• Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• Credentials added to Github CI. Instructions.
• /test connector=connectors/<name> command is passing.
• New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

• Grant edit access to maintainers (instructions)
• Secrets in the connector's spec are annotated with airbyte_secret
• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• Code reviews completed
• Documentation updated
  • Connector's README.md
  • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
• PR name follows PR naming conventions
• Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• Credentials added to Github CI. Instructions.
• /test connector=connectors/<name> command is passing.
• New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

• Issue acceptance criteria met
• PR name follows PR naming conventions
• If adding a new generator, add it to the list of scaffold modules being tested
• The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
• Documentation which references the generator is updated as needed.

[davinchia]

/test connector=source-shortio

🕑 source-shortio https://github.com/airbytehq/airbyte/actions/runs/1133923291
❌ source-shortio https://github.com/airbytehq/airbyte/actions/runs/1133923291

[davinchia]

Hmm I'm currently getting this 402 Client Error: Payment Required for url: https://api-v2.short.cm/statistics/domain/235589/last_clicks on testing.

Have escalated to shortio.

[davinchia]

/test connector=source-shortio

🕑 source-shortio https://github.com/airbytehq/airbyte/actions/runs/1134188458
✅ source-shortio https://github.com/airbytehq/airbyte/actions/runs/1134188458

[davinchia]

/publish connector=connectors/source-shortio

🕑 connectors/source-shortio https://github.com/airbytehq/airbyte/actions/runs/1134212049
✅ connectors/source-shortio https://github.com/airbytehq/airbyte/actions/runs/1134212049

[davinchia]

FYI @sherifnada there is some follow up on the account side but this is done on the code side. I haven't released this into our list yet - asked a question on Slack and will follow up after.

[davinchia]

@apostoltego this is released!