Source Stripe : Remove Updated field from schemas

[yevhenii-ldv]

What

closes #4921.

How

Describe the solution

Recommended reading order

1. x.java
2. y.python

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

• Issue acceptance criteria met
• PR name follows PR naming conventions
• Secrets are annotated with airbyte_secret in the connector's spec
• Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
• Unit & integration tests added as appropriate (and are passing)
  • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• /test connector=connectors/<name> command as documented here is passing.
  • Community members can skip this, Airbyters will run this for you.
• Code reviews completed
• Documentation updated
  • README.md
  • docs/SUMMARY.md if it's a new connector
  • Created or updated reference docs in docs/integrations/<source or destination>/<name>.
  • Changelog in the appropriate page in docs/integrations/.... See changelog example
  • docs/integrations/README.md contains a reference to the new connector
  • Build status added to build page
• Build is successful
• Connector version bumped like described here
• New Connector version released on Dockerhub by running the /publish command described here
• No major blockers
• PR merged into master branch
• Follow up tickets have been created
• Associated tickets have been closed & stakeholders notified

Connector Generator checklist

• Issue acceptance criteria met
• PR name follows PR naming conventions
• If adding a new generator, add it to the list of scaffold modules being tested
• The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
• Documentation which references the generator is updated as needed.

[avida]

Please rebase this change on latest master. Your SAT run would fail w/o it.

[yevhenii-ldv]

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1070514676
✅ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1070514676

[ChristopheDuong]

In normalization, we expect streams in catalog to always have json_schema.properties otherwise we raise exceptions:

airbyte/airbyte-integrations/bases/base-normalization/normalization/transform_catalog/catalog_processor.py

Line 143 in 953744a

properties = get_field(get_field(stream_config, "json_schema", message), "properties", message)

Why are we sending streams with empty schemas for?

[yevhenii-ldv]

@ChristopheDuong
In this case, we use configured_catalog.json for Acceptance Tests, and in order not to duplicate the scheme once again, a processing has been created that pulls up the scheme for each stream from the streams/ directory.
You can see it here.

In your case, we get a catalog that is located in the f"resources/{catalog_file}.json" file. I am not very competent in this code, since I have not worked with it, but I suspect that these catalogs were created using the discover command and placed in the resources/ directory, and json_schema is always present there.

[ChristopheDuong]

Oh i see, that's how the tests are done here, ok!

I was just worried that sources would produce streams with empty properties as it already happened in the past as shown recently in this thread:
https://airbytehq.slack.com/archives/C01MFR03D5W/p1627044823226100

[yevhenii-ldv]

No no, this is a different case. This practice of using catalogs without json_schema for Acceptance Tests is not new, it has been used for about month for sure with different connectors.

[yevhenii-ldv]

/publish connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1074819506
✅ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1074819506