-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Concurrent Low-Code] ConcurrentDeclarativeSource class that low-code connectors can inherit from to uptake Concurrent CDK #46662
Open
brianjlai
wants to merge
33
commits into
master
Choose a base branch
from
brian/concurrent_declarative_source
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,112
−380
Open
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
1130a74
initial work to create the ConcurrentDeclarativeSource that can run i…
brianjlai 54a1f85
Merge branch 'master' into brian/concurrent_declarative_source
brianjlai 0bd2deb
adding more tests and fixing bugs for only syncing streams in catalog…
brianjlai 2ad65d9
Merge branch 'master' into brian/concurrent_declarative_source
brianjlai 8861054
fix a few more merge conflict errors
brianjlai aa55ab7
Fix tests and add cursor granularity to the cursor partition generator
brianjlai 4288b8d
integrate YamlDeclarativeSource with ConcurrentDeclarativeSource and …
brianjlai 1650e30
Merge branch 'master' into brian/concurrent_declarative_source
brianjlai 98c42a7
rebase, formatting, fix tests, add new test cases for concurrency level
brianjlai 0f79069
forgot to remove change to test
brianjlai 5992e19
fix mypy errors and a few others bugs and testing
brianjlai 6a160c0
Merge branch 'master' into brian/concurrent_declarative_source
brianjlai b09311f
add logic to skip streams using non-thread safe stream_state, pr feed…
brianjlai 0180e11
fix formatting and mypy checks
brianjlai 0c0c019
Merge branch 'master' into brian/concurrent_declarative_source
brianjlai 61dfb9b
fix more mypy
brianjlai 5dd1121
mypy
brianjlai 7bd3056
pr feedback and updates to source-sentry for testing
brianjlai bef1c03
sentry lockfile
brianjlai c2e3bdb
update base image
brianjlai 9116da6
bump amplitude dependencies and versions for testing
brianjlai 80186ca
Merge branch 'master' into brian/concurrent_declarative_source
brianjlai 1242296
add logging for incremental streams that are not thread safe
brianjlai b74b942
Merge branch 'master' into brian/concurrent_declarative_source
brianjlai 99bee1e
remove amplitude version bump
brianjlai 15cb6dd
get rid of stream_state interpolation in sentry
brianjlai 9b5eb62
whatever
brianjlai b82c21c
parse DatetimeBasedCursorModel to ConcurrentCursor, bugfixes, pr feed…
brianjlai 6a91848
formatting + mypy
brianjlai 15127a7
fix mypy by replacing empty tuple() with None to make it truly optional
brianjlai 977c525
remove local cdk from sentry
brianjlai 4e38c4e
update lockfile
brianjlai f7f3e9d
swapped updating lockfiles
brianjlai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
265 changes: 265 additions & 0 deletions
265
airbyte-cdk/python/airbyte_cdk/sources/declarative/concurrent_declarative_source.py
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Regarding the
# type: ignore
that was already there before your changes: Should we just make it part of the interface then? I'm not sure whyConnectionChecker.check
does not only takeDeclarativeSource
then. It seems like even the typing forSource
is too large asstreams
is defined on theAbstractStream
level. It feels like updating the typing issue, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed temporary fix: https://github.com/airbytehq/airbyte/pull/46995/files#r1806474429