Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Harvest: fix broken spec file #4222

Merged
merged 1 commit into from
Jun 19, 2021

Conversation

tyschroed
Copy link
Contributor

What

Fixes #4221

How

Renames api_key to api_token to align with expected inputs, also updates documentationUrl to point to Harvest source docs.

Recommended reading order

  1. spec.json

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in output spec
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Documentation updated
    • README
    • CHANGELOG.md
    • Reference docs in the docs/integrations/ directory.
    • Build status added to build page
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

Connector Generator checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Jun 19, 2021
@marcosmarxm
Copy link
Member

oh! thanks a lot @tyschroed i'm going to test and bump the new version of the connector

@marcosmarxm marcosmarxm changed the title Source Harvest: fix broken spec file 🐛 Source Harvest: fix broken spec file Jun 19, 2021
@marcosmarxm marcosmarxm merged commit a0f27b3 into airbytehq:master Jun 19, 2021
@marcosmarxm
Copy link
Member

@tyschroed you should be able to upgrade the connector in the admin page to 0.1.2.

@tyschroed tyschroed deleted the 4221-harvest-source-broken branch June 21, 2021 15:58
@tyschroed
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating new Harvest source not working
2 participants