Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change JDBC ClickHouse version into 0.3.2-patch9 #13639

Merged
merged 4 commits into from
Jul 19, 2022

Conversation

mzitnik
Copy link
Contributor

@mzitnik mzitnik commented Jun 9, 2022

What

Changing ClickHouse JDBC Client to a newer version 0.3.2-patch9

How

Change dependency implementation group: 'com.clickhouse', name: 'clickhouse-jdbc', version: '0.3.2-patch9'
Fixing some method interface change

Recommended reading order

N/A

🚨 User Impact 🚨

Should not be

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@mzitnik
Copy link
Contributor Author

mzitnik commented Jun 9, 2022

I have fixed the email of the commit & should also solve the CLA because already was sign for another project

@marcosmarxm
Copy link
Member

marcosmarxm commented Jun 9, 2022

/test connector=connectors/destination-clickhouse

🕑 connectors/destination-clickhouse https://github.com/airbytehq/airbyte/actions/runs/2470233701
❌ connectors/destination-clickhouse https://github.com/airbytehq/airbyte/actions/runs/2470233701
🐛 https://gradle.com/s/7zqycdve67oga

Build Failed

Test summary info:

Could not find result summary

@mzitnik
Copy link
Contributor Author

mzitnik commented Jun 9, 2022

On my local environment build for clickhouse connector works with no errors (./gradlew :airbyte-integrations:connectors:destination-clickhouse:build)

@grishick
Copy link
Contributor

@mzitnik thank you for the contribution! Our CI currently does not work properly with forks. I am going to pull your fork, rebase on master, push to a different branch and create another PR.

@grishick
Copy link
Contributor

I will merge this change in this PR

@grishick grishick closed this Jun 10, 2022
@grishick grishick reopened this Jun 10, 2022
@CLAassistant
Copy link

CLAassistant commented Jun 10, 2022

CLA assistant check
All committers have signed the CLA.

@mzitnik mzitnik requested a review from a team as a code owner July 17, 2022 05:31
@grishick
Copy link
Contributor

Running full CI in this PR

@mzitnik
Copy link
Contributor Author

mzitnik commented Jul 19, 2022

@grishick fix the integration tests

@grishick grishick merged commit 36c659d into airbytehq:master Jul 19, 2022
@VitaliiMaltsev
Copy link
Contributor

@mzitnik seems like this PR broke integration tests for Clickhouse source
https://github.com/airbytehq/airbyte/actions/runs/2702828638

mfsiega-airbyte pushed a commit that referenced this pull request Jul 21, 2022
* change jdbc clickhoue verstion into 0.3.2-patch9

* running query by query & changing Docker version

Co-authored-by: mzitnik <[email protected]>
@grishick
Copy link
Contributor

@mzitnik seems like this PR broke integration tests for Clickhouse source https://github.com/airbytehq/airbyte/actions/runs/2702828638

Indeed. I missed this connection. We declare the JDBC driver in one place and that is used by source and destination. We should update source-clickhouse connector to use the new driver as well.

@grishick
Copy link
Contributor

@mzitnik seems like this PR broke integration tests for Clickhouse source https://github.com/airbytehq/airbyte/actions/runs/2702828638

I filed this issue to track the fix: #14945

@suhomud
Copy link
Contributor

suhomud commented Jul 22, 2022

@grishick this PR should fix those issues.
#14701
I updated clickhouse-jdbc and adapt source/destination connectors. Also it fixes all integration tests for source/destination including strict-encrypt for Mac OS Intel/M1, Ubuntu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants