-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change JDBC ClickHouse version into 0.3.2-patch9 #13639
Conversation
I have fixed the email of the commit & should also solve the CLA because already was sign for another project |
/test connector=connectors/destination-clickhouse
Build FailedTest summary info:
|
On my local environment build for clickhouse connector works with no errors (./gradlew :airbyte-integrations:connectors:destination-clickhouse:build) |
@mzitnik thank you for the contribution! Our CI currently does not work properly with forks. I am going to pull your fork, rebase on master, push to a different branch and create another PR. |
I will merge this change in this PR |
Running full CI in this PR |
@grishick fix the integration tests |
@mzitnik seems like this PR broke integration tests for Clickhouse source |
* change jdbc clickhoue verstion into 0.3.2-patch9 * running query by query & changing Docker version Co-authored-by: mzitnik <[email protected]>
Indeed. I missed this connection. We declare the JDBC driver in one place and that is used by source and destination. We should update source-clickhouse connector to use the new driver as well. |
I filed this issue to track the fix: #14945 |
What
Changing ClickHouse JDBC Client to a newer version 0.3.2-patch9
How
Change dependency implementation group: 'com.clickhouse', name: 'clickhouse-jdbc', version: '0.3.2-patch9'
Fixing some method interface change
Recommended reading order
N/A
🚨 User Impact 🚨
Should not be
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.