🎉 Source Freshdesk: Added new streams #13332

lgomezm · 2022-05-31T13:58:05Z

What

Fixes Support all available entities in Source Freshdesk #1387.
The Freshdesk source connector only provides a subset of streams from all its available APIs.

How

Adds full stream coverage.

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

alafanechere · 2022-05-31T18:15:59Z

Hey @lgomezm thank you for this contribution!
I'll run the acceptance tests and will go for a first review once they pass.

alafanechere · 2022-05-31T18:16:13Z

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2416901364
❌ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2416901364
🐛 https://gradle.com/s/wfb57zkkr3qv6

Build Failed

Test summary info:

Could not find result summary

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2416901364
❌ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2416901364
🐛 https://gradle.com/s/ilae3t5lvu4o6

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED unit_tests/test_streams.py::test_incremental[Tickets-tickets] - Assert...
	 FAILED unit_tests/test_streams.py::test_incremental[SatisfactionRatings-surveys/satisfaction_ratings]
	 �[31m================== �[31m�[1m2 failed�[0m, �[32m38 passed�[0m, �[33m166 warnings�[0m�[31m in 3.91s�[0m�[31m ==================�[0m

lgomezm · 2022-06-01T02:47:39Z

Hi @alafanechere. I have fixed formatting. That check should pass now.

alafanechere

@lgomezm two tests are failing because of a date format issue I think.

test_incremental[Tickets-tickets]
test_incremental[SatisfactionRatings-surveys/satisfaction_ratings]

	 E       AssertionError: assert '2022-04-01T00:00:00Z' == '2022-04-25T22:00:00Z'
	 E         - 2022-04-25T22:00:00Z
	 E         ?         ^^ ^^
	 E         + 2022-04-01T00:00:00Z
	 E         ?         ^^ ^^

lgomezm · 2022-06-01T14:00:07Z

Hi @alafanechere. I've updated the unit tests to fix the issue. It had to do with ranges when calling random.randint. PTAL again when you get a chance.

alafanechere · 2022-06-02T08:22:51Z

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2426984575
✅ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2426984575
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                           Stmts   Miss  Cover
--------------------------------------------------
source_freshdesk/source.py        31      0   100%
source_freshdesk/__init__.py       2      0   100%
source_freshdesk/streams.py      211      3    99%
source_freshdesk/utils.py         20      1    95%
--------------------------------------------------
TOTAL                            264      4    98%

Build Passed

Test summary info:

All Passed

alafanechere

@lgomezm I just made some minor formatting changes in your json schema. Otherwise LGTM. Thank you !!!

alafanechere · 2022-06-03T12:32:12Z

/publish connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2434615622
🚀 Successfully published connectors/source-freshdesk
🚀 Auto-bumped version for connectors/source-freshdesk
✅ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2434615622

* master: (142 commits) Highlight removed and added streams in Connection form (airbytehq#13392) 🐛 Source Amplitude: Fixed JSON Validator `date-time` validation (airbytehq#13373) 🐛 Source Mixpanel: publish v0.1.17 (airbytehq#13450) Fixed reverted PR: Fix cancel button when it doesn't provide feedback to the user + UX improvements (airbytehq#13388) 🎉 Source Freshdesk: Added new streams (airbytehq#13332) Prepare YamlSeedConfigPersistence for dependency injection (airbytehq#13384) helm chart: Support nodeSelector, tolerations and affinity on the booloader pod (airbytehq#11467) airbyte-api: add jackson model annotations to remove null values from responses (airbytehq#13370) Change stage to `beta` (airbytehq#13422) 🐛 Source Google Sheets: Retry on server errors (airbytehq#13446) Improve kube deploy process. (airbytehq#13397) Helm chart dependencies fix (airbytehq#13432) 🐛 Source HubSpot: Transform `contact_lists` data to comply with schema (airbytehq#13218) airbytehq#11758: Source Google Ads to GA (airbytehq#13441) Add more pr actions to tag pull requests (airbytehq#13437) Source Google Ads: drop schema field that filters out the data from stream (airbytehq#13423) Updates error view with new design (airbytehq#13197) Source MSSQL: correct enum Standard method (airbytehq#13419) Update postgres doc about cdc publication (airbytehq#13433) run source acceptance tests against image built from branch (airbytehq#13401) ...

lgomezm added 14 commits April 29, 2022 08:25

Started migration

02dde83

Migrated more streams

45148e2

Refactored usage of authenticator

5b41137

Migrated tickets and conversations

9b8f152

Code cleaned up

4922269

Updated test_300_page.py file

c837615

Added source tests

a9f760e

Added stream tests

1f0cdbf

Updated test_300_page.py file

e31f51b

Added more streams

2d541c8

Added tests for new streams

8a95b1f

Fixed integration tests

3c72a9f

Added integrtation test catalog

5b1e462

Added more streams

f6b0f65

github-actions bot added the area/connectors Connector related issues label May 31, 2022

octavia-squidington-iii added the community label May 31, 2022

alafanechere self-assigned this May 31, 2022

Fixed formatting

280e986

alafanechere requested changes Jun 1, 2022

View reviewed changes

Fixed unit tests

748d736

bleonard added bounty connectors/source/freshdesk labels Jun 2, 2022

alafanechere added 2 commits June 3, 2022 14:29

format stream schemas

02ef0ab

bump version

7b669f4

github-actions bot added the area/documentation Improvements or additions to documentation label Jun 3, 2022

alafanechere approved these changes Jun 3, 2022

View reviewed changes

auto-bump connector version

e68c6d9

alafanechere merged commit 75e4114 into airbytehq:master Jun 3, 2022

lgomezm deleted the lgomez/freshdesk_more_streams branch June 3, 2022 13:37

octavia-squidington-iii mentioned this pull request Jun 3, 2022

Bump Airbyte version from 0.39.8-alpha to 0.39.9-alpha #13454

Merged

alafanechere added internal and removed bounty labels Jun 29, 2022

grishick mentioned this pull request Nov 29, 2022

Freshdesk source documentation does not list all supported streams #19890

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source Freshdesk: Added new streams #13332

🎉 Source Freshdesk: Added new streams #13332

lgomezm commented May 31, 2022

alafanechere commented May 31, 2022

alafanechere commented May 31, 2022 •

edited by github-actions bot

Loading

lgomezm commented Jun 1, 2022

alafanechere left a comment

lgomezm commented Jun 1, 2022

alafanechere commented Jun 2, 2022 •

edited by github-actions bot

Loading

alafanechere left a comment

alafanechere commented Jun 3, 2022 •

edited by github-actions bot

Loading

🎉 Source Freshdesk: Added new streams #13332

🎉 Source Freshdesk: Added new streams #13332

Conversation

lgomezm commented May 31, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

alafanechere commented May 31, 2022

alafanechere commented May 31, 2022 • edited by github-actions bot Loading

Build Failed

Build Failed

lgomezm commented Jun 1, 2022

alafanechere left a comment

Choose a reason for hiding this comment

lgomezm commented Jun 1, 2022

alafanechere commented Jun 2, 2022 • edited by github-actions bot Loading

Build Passed

alafanechere left a comment

Choose a reason for hiding this comment

alafanechere commented Jun 3, 2022 • edited by github-actions bot Loading

alafanechere commented May 31, 2022 •

edited by github-actions bot

Loading

alafanechere commented Jun 2, 2022 •

edited by github-actions bot

Loading

alafanechere commented Jun 3, 2022 •

edited by github-actions bot

Loading