Filter out unavailable connectors in cloud connector settings, enable Snapchat in cloud #13174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
edmundito
force-pushed
the
edmundito/filter-out-connectors-cloud
branch
from
5cf7db0
to
c756466
Compare
edmundito
added
area/frontend
and removed
area/frontend
* Move list of excluded connectors to connector constants * Add hook to filter out available connectors * Update settings connectorview component to filter out connectors * Add isCloudApp utility to check if the app is in cloud mode correctly
edmundito
force-pushed
the
edmundito/filter-out-connectors-cloud
branch
from
c756466
to
d0383c8
Compare
pedroslopez
reviewed
May 26, 2022
...e-webapp/src/views/Connector/ServiceForm/components/Controls/ConnectorServiceTypeControl.tsx
Show resolved
Hide resolved
...e-webapp/src/views/Connector/ServiceForm/components/Controls/ConnectorServiceTypeControl.tsx
Show resolved
Hide resolved
pedroslopez
approved these changes
May 27, 2022
vincentkoc
suggested changes
May 29, 2022
...e-webapp/src/views/Connector/ServiceForm/components/Controls/ConnectorServiceTypeControl.tsx
Show resolved
Hide resolved
|
Please rollback the removal of the notes |
timroes
reviewed
May 31, 2022
edmundito
changed the title
jscottpolevault
pushed a commit
to jscottpolevault/airbyte
that referenced
this pull request
Jun 1, 2022
… Snapchat in cloud (airbytehq#13174) * Filter out unavailable connectors in cloud connector settings * Move list of excluded connectors to connector constants * Add hook to filter out available connectors * Update settings connectorview component to filter out connectors * Add isCloudApp utility to check if the app is in cloud mode correctly * Remove Snapchat from filtered out list * Replace cloud check in index with util * Restore info about excluded connectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This update ensures that connectors not available in cloud are filtered out for cloud workspaces including the source and destination settings. It also fixes an issue where these excluded connectors were available locally for cloud development.
Additionally it enables Snapchat in cloud as it's ready to go.
Closes #12967
How
Reading order
Top to bottom