Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Zendesk-Support: fixed ticket_audits stream schema + fixed broken unit_test #13055

Merged
merged 4 commits into from
May 20, 2022

Conversation

bazarnov
Copy link
Collaborator

What

Resolving: #13019

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

No impact expected.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

@github-actions github-actions bot added the area/connectors Connector related issues label May 20, 2022
@bazarnov bazarnov linked an issue May 20, 2022 that may be closed by this pull request
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label May 20, 2022
@bazarnov
Copy link
Collaborator Author

bazarnov commented May 20, 2022

/test connector=connectors/source-zendesk-support

🕑 connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/2358619384
✅ connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/2358619384
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                                 Stmts   Miss  Cover
--------------------------------------------------------
source_zendesk_support/__init__.py       2      0   100%
source_zendesk_support/streams.py      293     53    82%
source_zendesk_support/source.py        45     17    62%
--------------------------------------------------------
TOTAL                                  340     70    79%

@bazarnov bazarnov requested a review from lazebnyi May 20, 2022 13:40
@bazarnov
Copy link
Collaborator Author

bazarnov commented May 20, 2022

/publish connector=connectors/source-zendesk-support

🕑 connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/2358697772
🚀 Successfully published connectors/source-zendesk-support
🚀 Auto-bumped version for connectors/source-zendesk-support
✅ connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/2358697772

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets May 20, 2022 14:13 Inactive
@bazarnov bazarnov merged commit bb139ec into master May 20, 2022
@bazarnov bazarnov deleted the bazarnov/source-zendesk-support-fix-schema branch May 20, 2022 14:13
suhomud pushed a commit that referenced this pull request May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Source Zendesk Support: fix tickets_audits stream schema
3 participants