Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDK: TypeTransformer.default_convert catch TypeError #12948

Merged
merged 4 commits into from
May 19, 2022

Conversation

grubberr
Copy link
Contributor

@grubberr grubberr commented May 18, 2022

Signed-off-by: Sergey Chvalyuk [email protected]

What

TypeTransformer.default_convert can raise TypeError exception in next cases:

data = {
    "some_number": [10, 10]
}

json_schema = {
  "$schema": "http://json-schema.org/draft-07/schema#",
  "type": "object",
  "properties": {
    "some_number": {"type": "number"},
  }
}

How

catch TypeError exception

@github-actions github-actions bot added the CDK Connector Development Kit label May 18, 2022
Signed-off-by: Sergey Chvalyuk <[email protected]>
Signed-off-by: Sergey Chvalyuk <[email protected]>
@grubberr
Copy link
Contributor Author

grubberr commented May 19, 2022

/publish-cdk dry-run=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/2349654080
https://github.com/airbytehq/airbyte/actions/runs/2349654080

@grubberr
Copy link
Contributor Author

grubberr commented May 19, 2022

/publish-cdk dry-run=false

🕑 https://github.com/airbytehq/airbyte/actions/runs/2349689062
https://github.com/airbytehq/airbyte/actions/runs/2349689062

@grubberr grubberr merged commit 9a960c4 into master May 19, 2022
@grubberr grubberr deleted the grubberr/12947-airbyte_cdk_transform branch May 19, 2022 04:32
suhomud pushed a commit that referenced this pull request May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDK: TypeTransformer.default_convert catch TypeError
2 participants