Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalization: Checking --event-buffer-size on old dbt crashed entrypoint.sh #12924

Merged
merged 3 commits into from
May 18, 2022

Conversation

grubberr
Copy link
Contributor

@grubberr grubberr commented May 17, 2022

Signed-off-by: Sergey Chvalyuk [email protected]

What

because entrypoint.sh script works in set -e mode
this line

dbt --help | grep -E -- '--event-buffer-size'

can kill script on old dbt (without event-buffer-size) because grep returns non-zero status

How

By-pass this case with help of checking function

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@github-actions github-actions bot added area/documentation Improvements or additions to documentation area/platform issues related to the platform area/worker Related to worker normalization labels May 17, 2022
@grubberr grubberr temporarily deployed to more-secrets May 17, 2022 17:00 Inactive
@grubberr grubberr temporarily deployed to more-secrets May 17, 2022 17:00 Inactive
Signed-off-by: Sergey Chvalyuk <[email protected]>
@grubberr grubberr temporarily deployed to more-secrets May 17, 2022 17:03 Inactive
@grubberr grubberr temporarily deployed to more-secrets May 17, 2022 17:03 Inactive
@grubberr grubberr self-assigned this May 17, 2022
@grubberr grubberr linked an issue May 17, 2022 that may be closed by this pull request
@grubberr grubberr temporarily deployed to more-secrets May 18, 2022 07:00 Inactive
@grubberr grubberr temporarily deployed to more-secrets May 18, 2022 07:00 Inactive
@grubberr
Copy link
Contributor Author

grubberr commented May 18, 2022

/publish connector=bases/base-normalization run-tests=false

🕑 bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/2343970859
🚀 Successfully published bases/base-normalization
❌ Couldn't auto-bump version for bases/base-normalization

@grubberr grubberr merged commit 7401cb6 into master May 18, 2022
@grubberr grubberr deleted the grubberr/12661-normalization-mysql branch May 18, 2022 08:08
suhomud pushed a commit that referenced this pull request May 23, 2022
…oint.sh (#12924)

* Fixed checking --event-buffer-size on old dbt crashed entrypoint.sh

Signed-off-by: Sergey Chvalyuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation area/platform issues related to the platform area/worker Related to worker normalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

normalization failed in mysql destination
3 participants