Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harshith/testpr 11443 #12867

Merged
merged 4 commits into from
May 16, 2022
Merged

Harshith/testpr 11443 #12867

merged 4 commits into from
May 16, 2022

Conversation

harshithmullapudi
Copy link
Contributor

What

closes #11443

@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented May 16, 2022 •
edited by github-actions bot
Loading

/test connector=source-pipedrive

🕑 source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/2331431470
✅ source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/2331431470
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        75      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_incremental.py        85     25    71%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  913    246    73%
Name                           Stmts   Miss  Cover
--------------------------------------------------
source_pipedrive/__init__.py       2      0   100%
source_pipedrive/source.py        36      2    94%
source_pipedrive/streams.py       77      8    90%
--------------------------------------------------
TOTAL                            115     10    91%

@github-actions github-actions bot added the area/connectors Connector related issues label May 16, 2022
@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets May 16, 2022 10:59 Inactive
@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets May 16, 2022 10:59 Inactive
@codecov
Copy link

codecov bot commented May 16, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@b077bb3). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #12867   +/-   ##
=========================================
  Coverage          ?   91.30%           
=========================================
  Files             ?        3           
  Lines             ?      115           
  Branches          ?        0           
=========================================
  Hits              ?      105           
  Misses            ?       10           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b077bb3...19bc34d. Read the comment docs.

@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented May 16, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-pipedrive auto-bump-version=false

🕑 connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/2331491081
🚀 Successfully published connectors/source-pipedrive
✅ connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/2331491081

@harshithmullapudi harshithmullapudi mentioned this pull request May 16, 2022
Closed
40 tasks
@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets May 16, 2022 11:57 Inactive
@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets May 16, 2022 11:57 Inactive
@harshithmullapudi harshithmullapudi merged commit 6578391 into master May 16, 2022
@harshithmullapudi harshithmullapudi deleted the harshith/testpr-11443 branch May 16, 2022 13:55
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request May 17, 2022
Merged
suhomud pushed a commit that referenced this pull request May 23, 2022
@harshithmullapudi @itaseskii @suhomud
Harshith/testpr 11443 (#12867)
9d27b5f 
* add unit tests

* add streams to tests

* fix: version already exists

* chore: update seed file

Co-authored-by: itaseski <[email protected]>
Co-authored-by: itaseski <[email protected]>
@alafanechere alafanechere mentioned this pull request Jun 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/connectors Connector related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshithmullapudi @itaseskii