End date configuration for tiktok #12838

Zawar92 · 2022-05-13T11:12:33Z

What

Want to add user specified end-date configuration for tiktok. This use case is important for us, as we require to refetch data for specific date ranges. As of now the connector fetch data from the start_date till current date.

How

Source configuration should allow for the specification of an end_date. It would be optional based on the current setup. If someone doesn't want to use the end_date, it's up-to them.

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

Zawar92 · 2022-05-13T11:15:38Z

Need assistance for the failing of unit test.

Failed Unit test,

airbyte-integrations/connectors/source-tiktok-marketing/unit_tests/unit_test.py::test_backoff
airbyte-integrations/connectors/source-tiktok-marketing/unit_tests/unit_test.py::test_random_items

What is required in config.json and prod_config.json?

When advertiser_id is not passed in config.json test_backoff fails.
When advertiser_id is passed in credentials in config.json then test_backoff is success but cannot retrieve the data, as it cannot retrieve the data test_random_items fails. Attached are the screen shots of my error.

My config.json

{
    "start_date": "2022-04-20",
    "end_date": "2022-04-25",
    "credentials": {
      "auth_type": "oauth2.0",
      "advertiser_id": "",
      "app_id": "",
      "secret": "",
      "access_token": ""
    }
}

Screen Shots of Error

Zawar92 · 2022-05-13T11:18:15Z

Submitted an issue previously. Source tiktok marketing: add end_date configuration

alafanechere · 2022-05-18T15:28:06Z

Thank you @Zawar92 for the contribution. @harshithmullapudi do you mind helping @Zawar92 solve the unit test and provide a review? 🙏

Zawar92 · 2022-05-19T12:38:06Z

I found this issue. I think it's related.
https://github.com/airbytehq/airbyte-internal-issues/issues/552

harshithmullapudi · 2022-05-23T10:10:38Z