fix: postgres string type #12836
Merged
fix: postgres string type #12836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosmarxm
requested changes
May 16, 2022
|
Hey @marcosmarxm, just added the TODO, in the meantime i'm going to also submit a PR to DBT repo |
edgao
reviewed
May 23, 2022
There was a problem hiding this comment.
@shrodingers I've got one question just to make sure I've modeled this correctly, but otherwise LGTM!
...tegrations/bases/base-normalization/dbt-project-template/macros/cross_db_utils/datatypes.sql
Outdated
Show resolved
Hide resolved
edgao
approved these changes
May 23, 2022
...tegrations/bases/base-normalization/dbt-project-template/macros/cross_db_utils/datatypes.sql
Outdated
Show resolved
Hide resolved
…late/macros/cross_db_utils/datatypes.sql Added the dbt upgrade condition to TODO Co-authored-by: Edward Gao <[email protected]>
|
Merging this I'll publish a new normalization version with #12699 |
marcosmarxm
approved these changes
May 27, 2022
jscottpolevault
pushed a commit
to jscottpolevault/airbyte
that referenced
this pull request
Jun 1, 2022
* fix: postgres string type * feat: added TODO for removal * fix: better comment style * Update airbyte-integrations/bases/base-normalization/dbt-project-template/macros/cross_db_utils/datatypes.sql Added the dbt upgrade condition to TODO Co-authored-by: Edward Gao <[email protected]> Co-authored-by: Edward Gao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Solves an issue with normalization on incremental sync on postgres destination when adding some columns after initial full refresh sync which type infers to string and whose length > 256
These columns were created with a 256 columns limit due to a DBT behaviour (already opened an issue here. They have something coming out about that in dbt_utils, but in the meantime I think it is better to override the type_string macro to use text instead of varchar (text is correctly handled by dbt)
How
Added an override on the type_string macro for postgres in normalization macros
🚨 User Impact 🚨
No breaking change, except the fact that string columns will now have type text instead of varchar
Linked to this Issue for more context