Source Hubspot - Log instructions to update scopes when hitting 403 HTTP error #12515

girarda · 2022-05-02T17:02:26Z

What

Add blurp so the users knows they need to update their scope permissions if we're hitting 403 errors.
This is en interim solution until we validate the permissions for all streams in the check function (Source Hubspot: 403 error on sync #12484)

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

girarda · 2022-05-02T17:03:03Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2259264775
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2259264775
🐛 https://gradle.com/s/h6ki5f7evpscq

This reverts commit 86db8ff.

girarda · 2022-05-02T17:14:57Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2259322935
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2259322935
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  896    259    71%
Name                         Stmts   Miss  Cover
------------------------------------------------
source_hubspot/errors.py         6      0   100%
source_hubspot/__init__.py       2      0   100%
source_hubspot/streams.py      713     61    91%
source_hubspot/source.py        69     12    83%
------------------------------------------------
TOTAL                          790     73    91%

girarda · 2022-05-02T17:34:46Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2259418326
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2259418326
🐛 https://gradle.com/s/tvfig6oaq64lu

girarda · 2022-05-02T18:11:10Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2259597144
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2259597144
🐛 https://gradle.com/s/tjhyi64oqfr5i

girarda · 2022-05-02T18:26:38Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2259674700
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2259674700
🐛 https://gradle.com/s/yyk3l6fwtc3yc

girarda · 2022-05-02T20:31:39Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2260276103
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2260276103
🐛 https://gradle.com/s/jfw36o46i5asc

girarda · 2022-05-02T22:30:24Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2260795702
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2260795702
🐛 https://gradle.com/s/f3tledu2lvpqe

sherifnada · 2022-05-03T00:01:00Z

airbyte-integrations/connectors/source-hubspot/source_hubspot/streams.py

+        except requests.exceptions.HTTPError as e:
+            status_code = e.response.status_code
+            if status_code == 403:
+                raise RuntimeError("Invalid permissions. Please ensure the all scopes are authorized for.")


we should say the stream name that broke here just so the user has actionable feedback

girarda · 2022-05-03T00:11:32Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2261158509
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2261158509
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  896    259    71%
Name                         Stmts   Miss  Cover
------------------------------------------------
source_hubspot/errors.py         6      0   100%
source_hubspot/__init__.py       2      0   100%
source_hubspot/streams.py      713     61    91%
source_hubspot/source.py        69     12    83%
------------------------------------------------
TOTAL                          790     73    91%

alafanechere · 2022-05-04T14:50:32Z

Hey @girarda, did you not publish this on purpose? The version is not bumped in source_definitions.yaml and spec.json

…TTP error (#12515) * read workflows * try except * Revert "read workflows" This reverts commit 86db8ff. * Check campaigns * Check by reading data * Check all streams * requests_mock.ANY * mock all http methods * Try with get and post * reset to master * log name * bump version

read workflows

86db8ff

github-actions bot added the area/connectors Connector related issues label May 2, 2022

girarda added 2 commits May 2, 2022 10:13

try except

bab930d

Revert "read workflows"

251f661

This reverts commit 86db8ff.

Check campaigns

01b8510

Check by reading data

5d556b7

girarda added 2 commits May 2, 2022 11:21

Check all streams

ddd3c27

requests_mock.ANY

6aa75b4

mock all http methods

2d24b88

Try with get and post

7a4fcbf

sherifnada reviewed May 3, 2022

View reviewed changes

girarda added 2 commits May 2, 2022 17:08

reset to master

fe97450

log name

2ebcfb4

girarda changed the title ~~Source Hubspot - Failing with 403 Client Error: Forbidden for url~~ Source Hubspot - Log instructions to update scopes when hitting 403 HTTP error May 3, 2022

bump version

fbd9d92

github-actions bot added the area/documentation Improvements or additions to documentation label May 3, 2022

girarda marked this pull request as ready for review May 3, 2022 00:19

girarda requested a review from sherifnada May 3, 2022 00:19

sherifnada approved these changes May 3, 2022

View reviewed changes

girarda merged commit ce1936e into master May 3, 2022

girarda deleted the alex/oc41 branch May 3, 2022 00:45

octavia-squidington-iii mentioned this pull request May 3, 2022

Bump Airbyte version from 0.36.6-alpha to 0.36.7-alpha #12535

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Hubspot - Log instructions to update scopes when hitting 403 HTTP error #12515

Source Hubspot - Log instructions to update scopes when hitting 403 HTTP error #12515

girarda commented May 2, 2022 •

edited

Loading

girarda commented May 2, 2022 •

edited by github-actions bot

Loading

girarda commented May 2, 2022 •

edited by github-actions bot

Loading

girarda commented May 2, 2022 •

edited by github-actions bot

Loading

girarda commented May 2, 2022 •

edited by github-actions bot

Loading

girarda commented May 2, 2022 •

edited by github-actions bot

Loading

girarda commented May 2, 2022 •

edited by github-actions bot

Loading

girarda commented May 2, 2022 •

edited by github-actions bot

Loading

sherifnada May 3, 2022

girarda commented May 3, 2022 •

edited by github-actions bot

Loading

alafanechere commented May 4, 2022

Source Hubspot - Log instructions to update scopes when hitting 403 HTTP error #12515

Source Hubspot - Log instructions to update scopes when hitting 403 HTTP error #12515

Conversation

girarda commented May 2, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

girarda commented May 2, 2022 • edited by github-actions bot Loading

girarda commented May 2, 2022 • edited by github-actions bot Loading

girarda commented May 2, 2022 • edited by github-actions bot Loading

girarda commented May 2, 2022 • edited by github-actions bot Loading

girarda commented May 2, 2022 • edited by github-actions bot Loading

girarda commented May 2, 2022 • edited by github-actions bot Loading

girarda commented May 2, 2022 • edited by github-actions bot Loading

sherifnada May 3, 2022

Choose a reason for hiding this comment

girarda commented May 3, 2022 • edited by github-actions bot Loading

alafanechere commented May 4, 2022

girarda commented May 2, 2022 •

edited

Loading

girarda commented May 2, 2022 •

edited by github-actions bot

Loading

girarda commented May 2, 2022 •

edited by github-actions bot

Loading

girarda commented May 2, 2022 •

edited by github-actions bot

Loading

girarda commented May 2, 2022 •

edited by github-actions bot

Loading

girarda commented May 2, 2022 •

edited by github-actions bot

Loading

girarda commented May 2, 2022 •

edited by github-actions bot

Loading

girarda commented May 2, 2022 •

edited by github-actions bot

Loading

girarda commented May 3, 2022 •

edited by github-actions bot

Loading