Destination Bigquery: Dataset location is a required field #12477

girarda · 2022-04-29T16:28:26Z

What

Make the dataset location a required field to avoid confusion

How

dataset location field is now required
dataset location field has no default value
dataset location field is now right under project id field

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

girarda · 2022-04-29T16:46:29Z

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/2246627880
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/2246627880
Python tests coverage:

Name                                                                                                                            Stmts   Miss  Cover
---------------------------------------------------------------------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                                                                                          2      0   100%
normalization/transform_catalog/reserved_keywords.py                                                                               13      0   100%
normalization/transform_catalog/__init__.py                                                                                         2      0   100%
normalization/destination_type.py                                                                                                  13      0   100%
normalization/__init__.py                                                                                                           4      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/models/airbyte_protocol.py     124      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/models/__init__.py               1      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/__init__.py                      2      0   100%
normalization/transform_catalog/destination_name_transformer.py                                                                   155      8    95%
normalization/transform_config/transform.py                                                                                       159     31    81%
normalization/transform_catalog/table_name_registry.py                                                                            174     34    80%
normalization/transform_catalog/utils.py                                                                                           34      7    79%
normalization/transform_catalog/dbt_macro.py                                                                                       22      7    68%
normalization/transform_catalog/catalog_processor.py                                                                              147     80    46%
normalization/transform_catalog/transform.py                                                                                       61     38    38%
normalization/transform_catalog/stream_processor.py                                                                               534    345    35%
---------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                                            1447    550    62%

girarda · 2022-04-29T17:29:31Z

/publish connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/2246825039
❌ Failed to publish connectors/destination-bigquery
❌ Couldn't auto-bump version for connectors/destination-bigquery

girarda · 2022-04-29T18:06:25Z

/publish connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/2246991875
❌ Failed to publish connectors/destination-bigquery
❌ Couldn't auto-bump version for connectors/destination-bigquery

girarda · 2022-04-29T19:11:37Z

/publish connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/2247274997
🚀 Successfully published connectors/destination-bigquery
❌ Couldn't auto-bump version for connectors/destination-bigquery

girarda · 2022-04-29T19:46:33Z

/publish connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/2247431275
🚀 Successfully published connectors/destination-bigquery-denormalized
🚀 Auto-bumped version for connectors/destination-bigquery-denormalized
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/2247431275

girarda · 2022-04-29T20:17:07Z

/publish connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/2247545885
❌ Couldn't auto-bump version for connectors/destination-bigquery

This reverts commit b482c54.

…o alex/oc209

girarda · 2022-04-29T21:07:48Z

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/2247752565
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/2247752565
Python tests coverage:

Name                                                                                                                            Stmts   Miss  Cover
---------------------------------------------------------------------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                                                                                          2      0   100%
normalization/transform_catalog/reserved_keywords.py                                                                               13      0   100%
normalization/transform_catalog/__init__.py                                                                                         2      0   100%
normalization/destination_type.py                                                                                                  13      0   100%
normalization/__init__.py                                                                                                           4      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/models/airbyte_protocol.py     124      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/models/__init__.py               1      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/__init__.py                      2      0   100%
normalization/transform_catalog/destination_name_transformer.py                                                                   155      8    95%
normalization/transform_config/transform.py                                                                                       159     31    81%
normalization/transform_catalog/table_name_registry.py                                                                            174     34    80%
normalization/transform_catalog/utils.py                                                                                           34      7    79%
normalization/transform_catalog/dbt_macro.py                                                                                       22      7    68%
normalization/transform_catalog/catalog_processor.py                                                                              147     80    46%
normalization/transform_catalog/transform.py                                                                                       61     38    38%
normalization/transform_catalog/stream_processor.py                                                                               534    345    35%
---------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                                            1447    550    62%

girarda · 2022-04-29T21:55:21Z

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/2247929257
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/2247929257
Python tests coverage:

Name                                                                                                                            Stmts   Miss  Cover
---------------------------------------------------------------------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                                                                                          2      0   100%
normalization/transform_catalog/reserved_keywords.py                                                                               13      0   100%
normalization/transform_catalog/__init__.py                                                                                         2      0   100%
normalization/destination_type.py                                                                                                  13      0   100%
normalization/__init__.py                                                                                                           4      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/models/airbyte_protocol.py     124      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/models/__init__.py               1      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/__init__.py                      2      0   100%
normalization/transform_catalog/destination_name_transformer.py                                                                   155      8    95%
normalization/transform_config/transform.py                                                                                       159     31    81%
normalization/transform_catalog/table_name_registry.py                                                                            174     34    80%
normalization/transform_catalog/utils.py                                                                                           34      7    79%
normalization/transform_catalog/dbt_macro.py                                                                                       22      7    68%
normalization/transform_catalog/catalog_processor.py                                                                              147     80    46%
normalization/transform_catalog/transform.py                                                                                       61     38    38%
normalization/transform_catalog/stream_processor.py                                                                               534    345    35%
---------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                                            1447    550    62%

* Dataset location is required * Update doc * Bump versions * reset * Bump * downgrade * Revert "downgrade" This reverts commit b482c54. * auto-bump connector version Co-authored-by: Octavia Squidington III <[email protected]>

Dataset location is required

033407f

github-actions bot added the area/connectors Connector related issues label Apr 29, 2022

Update doc

4375a3d

github-actions bot added the area/documentation Improvements or additions to documentation label Apr 29, 2022

girarda added 2 commits April 29, 2022 09:41

Bump versions

a0ded00

reset

93885d8

girarda changed the title ~~Dataset location is required~~ Destination Bigquery: Dataset location is a required field Apr 29, 2022

girarda temporarily deployed to more-secrets April 29, 2022 16:44 Inactive

girarda requested review from brianjlai and misteryeo April 29, 2022 16:45

girarda marked this pull request as ready for review April 29, 2022 16:45

brianjlai approved these changes Apr 29, 2022

View reviewed changes

Bump

6e78746

girarda temporarily deployed to more-secrets April 29, 2022 18:48 Inactive

downgrade

b482c54

girarda temporarily deployed to more-secrets April 29, 2022 20:16 Inactive

Revert "downgrade"

c60650b

This reverts commit b482c54.

girarda temporarily deployed to more-secrets April 29, 2022 20:30 Inactive

octavia-squidington-iii added 2 commits April 29, 2022 20:35

auto-bump connector version

c622f03

Merge branch 'alex/oc209' of https://github.com/airbytehq/airbyte int…

25325d5

…o alex/oc209

octavia-squidington-iii temporarily deployed to more-secrets April 29, 2022 20:37 Inactive

octavia-squidington-iii temporarily deployed to more-secrets April 29, 2022 20:40 Inactive

girarda merged commit 5530247 into master Apr 29, 2022

girarda deleted the alex/oc209 branch April 29, 2022 22:34

octavia-squidington-iii mentioned this pull request Apr 29, 2022

Bump Airbyte version from 0.36.5-alpha to 0.36.6-alpha #12485

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Destination Bigquery: Dataset location is a required field #12477

Destination Bigquery: Dataset location is a required field #12477

girarda commented Apr 29, 2022 •

edited

Loading

girarda commented Apr 29, 2022 •

edited by github-actions bot

Loading

girarda commented Apr 29, 2022 •

edited by github-actions bot

Loading

girarda commented Apr 29, 2022 •

edited by github-actions bot

Loading

girarda commented Apr 29, 2022 •

edited by github-actions bot

Loading

girarda commented Apr 29, 2022 •

edited by github-actions bot

Loading

girarda commented Apr 29, 2022 •

edited by github-actions bot

Loading

girarda commented Apr 29, 2022 •

edited by github-actions bot

Loading

girarda commented Apr 29, 2022 •

edited by github-actions bot

Loading

Destination Bigquery: Dataset location is a required field #12477

Destination Bigquery: Dataset location is a required field #12477

Conversation

girarda commented Apr 29, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

girarda commented Apr 29, 2022 • edited by github-actions bot Loading

girarda commented Apr 29, 2022 • edited by github-actions bot Loading

girarda commented Apr 29, 2022 • edited by github-actions bot Loading

girarda commented Apr 29, 2022 • edited by github-actions bot Loading

girarda commented Apr 29, 2022 • edited by github-actions bot Loading

girarda commented Apr 29, 2022 • edited by github-actions bot Loading

girarda commented Apr 29, 2022 • edited by github-actions bot Loading

girarda commented Apr 29, 2022 • edited by github-actions bot Loading

girarda commented Apr 29, 2022 •

edited

Loading

girarda commented Apr 29, 2022 •

edited by github-actions bot

Loading

girarda commented Apr 29, 2022 •

edited by github-actions bot

Loading

girarda commented Apr 29, 2022 •

edited by github-actions bot

Loading

girarda commented Apr 29, 2022 •

edited by github-actions bot

Loading

girarda commented Apr 29, 2022 •

edited by github-actions bot

Loading

girarda commented Apr 29, 2022 •

edited by github-actions bot

Loading

girarda commented Apr 29, 2022 •

edited by github-actions bot

Loading

girarda commented Apr 29, 2022 •

edited by github-actions bot

Loading