-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🤖 publish command: fix for version bumping multiple connectors in same PR #12397
Conversation
To run publish command with changes from this PR I have to run manually from actions page. I'll manually link to comments below. |
Faker publish
|
Openweather publish
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Can we trigger multiple publish commands in parallel or shall we run publish command sequentially?
Codecov Report
@@ Coverage Diff @@
## master #12397 +/- ##
=========================================
Coverage ? 93.67%
=========================================
Files ? 4
Lines ? 79
Branches ? 0
=========================================
Hits ? 74
Misses ? 5
Partials ? 0 Continue to review full report at Codecov.
|
@alafanechere for now it's still just one connector per publish command, but this minor fix should mean they can all run at the same time and still auto-bump successfully. (technically there is still a window of failure but it's very very small) |
Not sure why faker failed to publish, going to bump openweather again and test alongside a different connector |
apify
|
openweather
|
apify
|
openweather
|
…e PR (#12397) * add a git pull from origin master before commit auto changes * dummy bump 2 connectors * pull from current branch not master * auto-bump connector version * dummy bump 2 connectors * revert faker bump * auto-bump connector version * better descript in changelog * dummy bump... again * commit first, then pull merge, then push * auto-bump connector version * auto-bump connector version Co-authored-by: Octavia Squidington III <[email protected]>
What
#12276
How
add a pull from the current branch @ origin just before we add and commit the automated changes.
Notes
Doing some dummy bumping on connectors to test, choosing lesser used ones