Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken release stage labels/warnings #12326

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Fix broken release stage labels/warnings #12326

merged 1 commit into from
Apr 26, 2022

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Apr 25, 2022

What

Fixes #12324
Fixes #12321

#12252 broke two labels by mistyped i18n ids. This PR fixes those ids.

@timroes timroes requested a review from a team as a code owner April 25, 2022 21:40
@github-actions github-actions bot added area/frontend area/platform issues related to the platform labels Apr 25, 2022
teallarson
teallarson approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@teallarson teallarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right. Did not test locally.

krishnaglick
krishnaglick approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@krishnaglick krishnaglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I looked over this PR I totally missed this typo!
Should we prioritize type-checking i18n translations?

@timroes timroes merged commit c19a671 into master Apr 26, 2022
@timroes timroes deleted the tim/fix-ga-icon branch April 26, 2022 14:34
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Apr 27, 2022
Merged
suhomud pushed a commit that referenced this pull request May 23, 2022
@timroes @suhomud
Fix broken release stage labels/warnings (#12326)
fdb7795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teallarson teallarson teallarson approved these changes

@krishnaglick krishnaglick krishnaglick approved these changes

Assignees
No one assigned
Labels
area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
3 participants
@timroes @krishnaglick @teallarson