Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Destination Postgres: Add jdbc_url_params input #12195

Merged
merged 3 commits into from
Apr 25, 2022

Conversation

noahkawasaki-airbyte
Copy link
Contributor

@noahkawasaki-airbyte noahkawasaki-airbyte commented Apr 20, 2022

What

Support additional JDBC connection options for postgres destination

How

Add jdbc_url_params input into Postgres Destination Spec and configBuilder obj to extend implementation from #10421

Closes #10720

Bumping to 0.3.19 from 0.3.17 because #11877 is in progress and bumping to 0.3.18

Recommended reading order

  1. PostgresDestination.java
  2. PostgresDestinationTest.java

🚨 User Impact 🚨

None, an opt-in feature

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Apr 20, 2022
@noahkawasaki-airbyte noahkawasaki-airbyte changed the title Add jdbc_url_params input for Destination Postgres 🎉 Destination Postgres: Add jdbc_url_params input Apr 20, 2022
@noahkawasaki-airbyte
Copy link
Contributor Author

noahkawasaki-airbyte commented Apr 21, 2022

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2203812806
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2203812806
No Python unittests run

@noahkawasaki-airbyte noahkawasaki-airbyte merged commit d46058e into master Apr 25, 2022
@noahkawasaki-airbyte noahkawasaki-airbyte deleted the noah/postges-destination-jdbc-params branch April 25, 2022 15:12
@noahkawasaki-airbyte
Copy link
Contributor Author

noahkawasaki-airbyte commented Apr 25, 2022

/publish connector=connectors/destination-postgres

🕑 connectors/destination-postgres https://github.com/airbytehq/airbyte/actions/runs/2221109204
❌ Failed to publish connectors/destination-postgres
❌ Couldn't auto-bump version for connectors/destination-postgres

@noahkawasaki-airbyte
Copy link
Contributor Author

/publish connector=connectors/destination-postgres

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Destination Postgres: custom JDBC parameters
2 participants