gradle: create a separate sub build for all connectors #11833
Conversation
| @@ -28,8 +28,8 @@ if (!System.getenv().containsKey("SUB_BUILD")) { | |||
| } else { | |||
| def subBuild = System.getenv().get("SUB_BUILD") | |||
There was a problem hiding this comment.
Now that this is getting used in more places, it might be nice to move it up a level in visibility, so the below doesn't have to repeat itself much.
There was a problem hiding this comment.
Could you please clarify? This sub-build is only defined in this settings file and is already at top level of the file.
There was a problem hiding this comment.
I meant you could have move the variable definition def subBuild = System.getenv().get("SUB_BUILD") to higher up in the file and then used it below instead of System.getenv().containsKey("SUB_BUILD") around line 79 below. Not a huge deal.
| @@ -28,8 +28,8 @@ if (!System.getenv().containsKey("SUB_BUILD")) { | |||
| } else { | |||
There was a problem hiding this comment.
The comment just above here is out of date now. Add ALL_CONNECTORS to the list. It's minor but I think just CONNECTORS would be fine too and maybe more intuitive.
There was a problem hiding this comment.
I use ALL_CONNECTORS to distinguish it from CONNECTORS_BASE.
|
NIT: I think it worth sharing that in #dev after merging so the team know that they can a new alias once merge. |
What
The
/test connectors=allcommand is selecting and running octavia-cli's integrationTest but it should not.How
Create a separate sub-build for all connectors that is not including octavia-cli.