Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs sidebar #11817

Merged
merged 4 commits into from
Apr 7, 2022
Merged

Add docs sidebar #11817

merged 4 commits into from
Apr 7, 2022

Conversation

supertopher
Copy link
Contributor

@supertopher supertopher commented Apr 7, 2022

What

Adds sidebar with the same layout as the old sidebar

How

Wrote JSON to match the format provided from the old docs

It's sketchy JSON let's commit before we break i
summary.md is no longer functional
it's higherarchy was translated into sidebar.js
as a JSON format that docusaurus likes
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Apr 7, 2022
@supertopher supertopher temporarily deployed to more-secrets April 7, 2022 20:04 Inactive
@supertopher supertopher temporarily deployed to more-secrets April 7, 2022 20:05 Inactive
@supertopher
Copy link
Contributor Author

Sidebar.js is a large part of this commit and doesn't show by default

@@ -1,15 +1,70 @@
# docs (by Docusaurus)
# Introduction
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a copy of /README.md Docusaurus doesn't like doing above it's root directory. I tried a symlink and the link appears to fail docusaurus's build steps so I just copied to move past the problem as a blocker

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we have a duplicate? If we can't figure this out, we could change the workflow to copy the top level readme in this directory as part of the workflow.

@Amruta-Ranade do you have thoughts on the repo readme vs the docs.airbyte.io readme? We've kept it the same for continuity. I want to continue doing so and was wondering if you have other plans.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do have plans to edit the landing page text. The repo readme is perfect for the OSS audience but I'd like the docs readme to be more user-centric. Keeping them separate makes sense to me.

@supertopher supertopher marked this pull request as ready for review April 7, 2022 20:30
@supertopher
Copy link
Contributor Author

Screen Shot 2022-04-07 at 1 30 59 PM

@supertopher supertopher temporarily deployed to more-secrets April 7, 2022 21:13 Inactive
@supertopher supertopher temporarily deployed to more-secrets April 7, 2022 21:13 Inactive
Copy link
Contributor

@Amruta-Ranade Amruta-Ranade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woooo!!

@supertopher
Copy link
Contributor Author

pushing to update docs

@supertopher supertopher merged commit c8337ea into master Apr 7, 2022
@supertopher supertopher deleted the add_docs_sidebar branch April 7, 2022 21:16
const sidebars = {
// By default, Docusaurus generates a sidebar from the docs folder structure
tutorialSidebar: [{type: 'autogenerated', dirName: '.'}],
module.exports = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the was the one done by hand?

@davinchia
Copy link
Contributor

Nicely done. Is this now live on doc.airbyte.io?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants