📖 Add clarity on automatic version bump in docs / PR checklist #11813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/documentation
edgao
approved these changes
Apr 7, 2022
| @@ -124,8 +124,8 @@ Once you've finished iterating on the changes to a connector as specified in its | |||
| /publish connector=(connectors|bases)/<connector_name> | |||
| ``` | |||
|
|
|||
| 4. OPTIONAL: Only necessary if the automated connector version bump fails | |||
| * Update the connector definition in the Airbyte connector index to use the new version: | |||
| 4. OPTIONAL: Necessary if this is a new connector, or the automated connector version bump fails | |||
There was a problem hiding this comment.
if the bump fails, that fails the entire /publish command right? I.e. you'd have to rerun /publish, at which point it would try to bump again?
There was a problem hiding this comment.
I kept the flow the same order as before, so first it publishes the connector and if that succeeds, it then does the auto version bump.
That means it can successfully publish but then fail auto-bump, this shouldn't happen so if it does, manual eyes figuring out why is a good thing. This should be clear based on the comments that get added back to the git comment.
This was referenced Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removed manual steps from PR checklist that are now automated (#11712)