Update prettier and add import sorting #11742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/frontend
area/platform
krishnaglick
approved these changes
Apr 6, 2022
| @@ -6,8 +6,7 @@ const BigButton = styled(Button)<{ shadow?: boolean }>` | |||
| line-height: 19px; | |||
| padding: 10px 27px; | |||
| font-weight: 500; | |||
| box-shadow: ${({ shadow }) => | |||
| shadow ? "0 8px 5px -5px rgba(0, 0, 0, 0.2)" : "none"}; | |||
| box-shadow: ${({ shadow }) => (shadow ? "0 8px 5px -5px rgba(0, 0, 0, 0.2)" : "none")}; | |||
There was a problem hiding this comment.
Should this be $shadow?
| @@ -14,8 +14,7 @@ type IProps = { | |||
| const Title = styled(H5)<{ light?: boolean }>` | |||
| padding: ${({ light }) => (light ? "19px 20px 20px" : "25px 25px 22px")}; | |||
| color: ${({ theme }) => theme.darkPrimaryColor}; | |||
| box-shadow: ${({ light, theme }) => | |||
| light ? "none" : `0 1px 2px ${theme.shadowColor}`}; | |||
| box-shadow: ${({ light, theme }) => (light ? "none" : `0 1px 2px ${theme.shadowColor}`)}; | |||
There was a problem hiding this comment.
Not sure it's worth fixing all the $ stuff for the css.
This was referenced Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates prettier as well as sets the line width to 120 (discussed offline).
Since it anyway touches all the files, we also enabled automatic import sorting on all files.
The only files touched manually in this PR where package.json, .prettierrc.js and .eslintrc. The rest of the changes are automatic eslint fixes (formatting).