Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Zendesk Support: fix the bug when state was not parsed correctly #11727

Merged
merged 4 commits into from
Apr 5, 2022

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Apr 5, 2022

What

From Slack conversation:

Anyone else encountering a bug with Zendesk Support 0.2.3
(I just upgraded and had to downgrade back to 0.1.12)
where the jobs just fail and the final message is $method? Can post logs shortly.

Logs:
logs-6110.txt

How

  • added new method check_stream_state to correctly handle the occasions when state could be missing or None
  • added unit_test to cover these cases

🚨 User Impact 🚨

No user impact expected.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@bazarnov bazarnov self-assigned this Apr 5, 2022
@github-actions github-actions bot added the area/connectors Connector related issues label Apr 5, 2022
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Apr 5, 2022
@bazarnov bazarnov temporarily deployed to more-secrets April 5, 2022 10:22 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets April 5, 2022 10:22 Inactive
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@6a60314). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #11727   +/-   ##
=========================================
  Coverage          ?   76.03%           
=========================================
  Files             ?        3           
  Lines             ?      338           
  Branches          ?        0           
=========================================
  Hits              ?      257           
  Misses            ?       81           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a60314...8324268. Read the comment docs.

@bazarnov
Copy link
Collaborator Author

bazarnov commented Apr 5, 2022

/test connector=connectors/source-zendesk-support

🕑 connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/2095635636
✅ connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/2095635636
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                                 Stmts   Miss  Cover
--------------------------------------------------------
source_zendesk_support/__init__.py       2      0   100%
source_zendesk_support/streams.py      291     56    81%
source_zendesk_support/source.py        45     25    44%
--------------------------------------------------------
TOTAL                                  338     81    76%

@bazarnov bazarnov temporarily deployed to more-secrets April 5, 2022 10:50 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets April 5, 2022 10:50 Inactive
@bazarnov
Copy link
Collaborator Author

bazarnov commented Apr 5, 2022

/publish connector=connectors/source-zendesk-support

🕑 connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/2096707562
❌ connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/2096707562
🕑 connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/2096707562
✅ connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/2096707562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants