Remove additional db calls when building connections for a workspace #11529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Improve performance of retrieving the connections of a workspace
How
The current logic makes some unnecessary calls, previous changes have already introduced a way to retrieve all the connections for a workspace. The connections handler continue to do individual calls to retrieve the details of each of those connections which is not needed.
This also fix some tests in ConnectionHandlerTest that broke as part of that change. The tests fixtures have some flaws (
standardSyncandstandardSyncDeletedhave the id). I think testing the conversion from StandardSync to ConnectionRead should be part of a test suite forApiPojoConverterand not thatConnectionHandler.Recommended reading order