🎉 Source Amazon Ads: Implement OAuth2.0 #11430
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| /* | ||
| * Copyright (c) 2021 Airbyte, Inc., all rights reserved. | ||
| */ | ||
|
|
||
| package io.airbyte.oauth.flows; | ||
|
|
||
| import com.fasterxml.jackson.databind.JsonNode; | ||
| import com.google.common.collect.ImmutableMap; | ||
| import io.airbyte.config.persistence.ConfigRepository; | ||
| import io.airbyte.oauth.BaseOAuth2Flow; | ||
| import java.io.IOException; | ||
| import java.net.URISyntaxException; | ||
| import java.net.http.HttpClient; | ||
| import java.util.Map; | ||
| import java.util.UUID; | ||
| import java.util.function.Supplier; | ||
| import org.apache.http.client.utils.URIBuilder; | ||
|
|
||
| public class AmazonAdsOAuthFlow extends BaseOAuth2Flow { | ||
|
There was a problem hiding this comment. can you add a unit test for this please? |
||
|
|
||
| private static final String AUTHORIZE_URL = "https://www.amazon.com/ap/oa"; | ||
| private static final String ACCESS_TOKEN_URL = "https://api.amazon.com/auth/o2/token"; | ||
|
|
||
| public AmazonAdsOAuthFlow(final ConfigRepository configRepository, final HttpClient httpClient) { | ||
| super(configRepository, httpClient); | ||
| } | ||
|
|
||
| public AmazonAdsOAuthFlow(final ConfigRepository configRepository, final HttpClient httpClient, final Supplier<String> stateSupplier) { | ||
| super(configRepository, httpClient, stateSupplier); | ||
| } | ||
|
|
||
| /** | ||
| * Depending on the OAuth flow implementation, the URL to grant user's consent may differ, | ||
| * especially in the query parameters to be provided. This function should generate such consent URL | ||
| * accordingly. | ||
| * | ||
| * @param definitionId The configured definition ID of this client | ||
| * @param clientId The configured client ID | ||
| * @param redirectUrl the redirect URL | ||
| */ | ||
| @Override | ||
| protected String formatConsentUrl(final UUID definitionId, | ||
| final String clientId, | ||
| final String redirectUrl, | ||
| final JsonNode inputOAuthConfiguration) | ||
| throws IOException { | ||
| try { | ||
| return new URIBuilder(AUTHORIZE_URL) | ||
| .addParameter("client_id", clientId) | ||
| .addParameter("scope", "advertising::campaign_management") | ||
| .addParameter("response_type", "code") | ||
| .addParameter("redirect_uri", redirectUrl) | ||
| .addParameter("state", getState()) | ||
| .build().toString(); | ||
| } catch (final URISyntaxException e) { | ||
| throw new IOException("Failed to format Consent URL for OAuth flow", e); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| protected Map<String, String> getAccessTokenQueryParameters(final String clientId, | ||
| final String clientSecret, | ||
| final String authCode, | ||
| final String redirectUrl) { | ||
| return ImmutableMap.<String, String>builder() | ||
| // required | ||
| .put("client_id", clientId) | ||
| .put("redirect_uri", redirectUrl) | ||
| .put("client_secret", clientSecret) | ||
| .put("code", authCode) | ||
| .put("grant_type", "authorization_code") | ||
| .build(); | ||
| } | ||
|
|
||
| /** | ||
| * Returns the URL where to retrieve the access token from. | ||
| * | ||
| */ | ||
| @Override | ||
| protected String getAccessTokenUrl(final JsonNode inputOAuthConfiguration) { | ||
| return ACCESS_TOKEN_URL; | ||
| } | ||
|
|
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was scope removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to amazon auth docs we need only scope to get
refresh_token.and we don't need scope to exchange
refresh_token->access_token.It means scope is useless here because we already have
refresh_tokenas connector input parameter.I this PR I moved
scopefrom python side to Java sidebecause we need scope only on stage where we get
refresh_token